search

JACoders / OpenJK

Community effort to maintain and improve Jedi Academy (SP & MP) + Jedi Outcast (SP only) released by Raven Software
GNU General Public License v2.0
2.03k stars 614 forks source link

SDL 1.2 Support #106

Closed TobiasKarnat closed 11 years ago

TobiasKarnat commented 11 years ago

Please add support for linking with SDL 1.2 for older unix systems.

eezstreet commented 11 years ago

By the time that it would take to support SDL 1.2, most distros would already support SDL 2. There's no real point in adding in support for 1.2 if it would be pointless to include it in the first place in like a month or two.

mrwonko commented 11 years ago

Is it really that hard to implement a new input/window/sound system? Then we should improve that. Adding support should ideally be a simple matter. I'll look into this at some point, there's not really a reason not to support SDL 1.2 besides slight bloat.

aisouard commented 11 years ago

It would be nice if TobiasKarnat could detail what's wrong with SDL2 on older unix systems.

eezstreet commented 11 years ago

SDL 2 is official in May. Why include support for something which is useless to support in a month's time.

Sent from my Windows Phone

From: Willi Schinmeyermailto:notifications@github.com Sent: ‎4/‎13/‎2013 5:37 PM To: Razish/OpenJKmailto:OpenJK@noreply.github.com Cc: eezstreetmailto:eezstreet@live.com Subject: Re: [OpenJK] SDL 1.2 Support (#106)

Is it really that hard to implement a new input/window/sound system? Then we should improve that. Adding support should ideally be a simple matter. I'll look into this at some point, there's not really a reason not to support SDL 1.2 besides slight bloat.

Reply to this email directly or view it on GitHub: https://github.com/Razish/OpenJK/issues/106#issuecomment-16341355

shinyquagsire23 commented 11 years ago

Not to mention it isn't all that hard to build from source, and packages are available for the lazy. I think. The only problem with SDL2 at the moment is that it's technically unsupported officially, and packages may not be available on some distros.

Either way, why support something that going to be unsupported in a month?

TobiasKarnat commented 11 years ago

For advanced users it's simple to back port libraries. Harder for novice users or if you need to cross compile. The fast release cycle of distros are nice, but why install a new os when the old runs stable? I wouldn't want support as it is free software, but be able to compile it without a bunch of extra libraries. Usually a project supports a lot of compilers, so why not this library?

eezstreet commented 11 years ago

I tend to agree with shinyquagsire. If we put in SDL 2 as some sort of prebuilt thing, or have people compile it alongside the engine, there's no big issue there.

KaldNL commented 11 years ago

While I'm not really against using SDL2, I do share Tobias' concerns for "old" Linux distros. Linux is not the same as Windows or OS X; packages are more tightly integrated with the system and it isn't always as easy as simply telling the user to get a newer version. Keep in mind the people who will be playing OpenJK aren't all going to be power users.

The current major distributions (Ubuntu 12.10, Fedora 18, OpenSUSE 12.3) do not have SDL2 by default. The upcoming Ubuntu 13.04 also does not seem to have SDL2. Further, a lot of users are not comfortable having to upgrade certain parts of their distribution or add extra repos just to be able to play one game. The release date of SDL2 is irrelevant to current distros.

eezstreet commented 11 years ago

Several Linux communities are reporting that we are not supporting SDL 1.2, so I'm going to close this one since quite a significant length of time has passed at any rate.

TobiasKarnat commented 11 years ago

Because the community reports? What kind of excuse is this?

As opensaber wrote the major distributions do not have SDL2 by default. Is it so hard to add SDL 1.2 support?

eezstreet commented 11 years ago

It really doesn't affect me at all. All I'm saying is, SDL 2.0 is getting released officially in a few weeks, and seeing how 24 days have passed since the last meaningful point of conversation on the matter and we've still gotten nowhere with this, I see no reason whatsoever to spend time on adding in extra support when it's only going to get removed very quickly. If you or opensaber want to add it in, be my guest, but don't really expect it to be very widely used since it's been reported in several *nix communities to be supporting SDL 1.2. Protip: If it's relatively obsolete, going to be obsolete soon, going to add extra overhead, going to make CMake and the file structure more messy than it already is, and/or not widely used at all, I don't really see why it should be added. But frankly, if people/Linux distros don't support 2.0 by year's end, people need to get with the times. A couple of notable games (including one by Icculus, I should mention) are using 2.0 fairly exclusively already, and it's not exactly like you need anything that isn't a clunker in order to keep up with SDL's low requirements..so what's the issue here.

Date: Sat, 11 May 2013 23:56:45 -0700 From: notifications@github.com To: OpenJK@noreply.github.com CC: eezstreet@live.com Subject: Re: [OpenJK] SDL 1.2 Support (#106)

Because the community reports? What kind of excuse is this?

As opensaber wrote the major distributions do not have SDL2 by default. Is it so hard to add SDL 1.2 support?

— Reply to this email directly or view it on GitHub.