search

JACoders / OpenJK

Community effort to maintain and improve Jedi Academy (SP & MP) + Jedi Outcast (SP only) released by Raven Software
GNU General Public License v2.0
2.01k stars 614 forks source link

Multiplayer RoffSystem Fixes #1165

Closed Daggolin closed 1 year ago

Daggolin commented 1 year ago

This pull request fixes two multiplayer bugs related to the RoffSystem:

  1. The RoffSystem used the wrong time value (engine time rather than module time) since the times were separated in 92e12a9e9b19525c1f589f1f6779e9397b6bfd26. This caused playback to be incorrect after the first mapchange. The same bug was also introduced by jk2mv and has been fixed the same way in https://github.com/mvdevs/jk2mv/commit/11a108ed4c495b0808f9f15f72f1668149cc4b49.
  2. The RoffSystem used long instead if int for the mVersion header field, causing 64-bit versions to be unable to parse roff files and playing them back.
ensiform commented 1 year ago

Are either of these affected in SP as well?

Daggolin commented 1 year ago

Are either of these affected in SP as well?

No. For SP the relevant roff functions should be in module code and use level.time. The mVersion type has been fixed for SP since 10dca1d9f3a3b9527ab19eac588f54275759bc32.