[MP] Hoist anti fakeplayer code into engine

JACoders / OpenJK

Community effort to maintain and improve Jedi Academy (SP & MP) + Jedi Outcast (SP only) released by Raven Software

GNU General Public License v2.0

1.97k stars 606 forks source link

[MP] Hoist anti fakeplayer code into engine #1205

Open Razish opened 4 months ago

Razish commented 4 months ago

Fixed connection status checks in g_antiFakePlayer. Replicated the check in the engine.

g_antiFakePlayer -> sv_antiFakePlayer
g_maxConnPerIP -> sv_maxConnPerIP

Fixes #1146

bartrpe commented 4 months ago

As far as I understand the problem in Issue #1146 , wouldn't it also work to make sure IPstring is purged on disconnect? What would make the solution here better?

TomArrow commented 4 months ago

As far as I understand the problem in Issue #1146 , wouldn't it also work to make sure IPstring is purged on disconnect? What would make the solution here better?

If it was cleared in game module that might be fine. If in server, not so good. It'd be nice to solve this in a way that doesn't require an engine update.

That said, this is a nice and long overdue cleanup of the code either way and certainly can't hurt.

Also, is it possible that the ip is not deleted in order to detect reconnets?