[SP] Font fixes - Githubissues

JACoders / OpenJK

Community effort to maintain and improve Jedi Academy (SP & MP) + Jedi Outcast (SP only) released by Raven Software

GNU General Public License v2.0

2.01k stars 614 forks source link

[SP] Font fixes #1227

Closed Daggolin closed 6 months ago

Daggolin commented 6 months ago

This pull request fixes 2 bugs in SP:

the datapad showed incorrect fonts for the weapons and force tabs (#1226)
the r_reloadfonts command made all fonts vanish

Additionally it adjusts MenuFontToReal in the ui module to be more flexible in case of menu files that don't actually load the default fonts.

Daggolin commented 6 months ago

What a mess that font code is, thanks for dealing with it.

Well, I was the one who ported the JK2MV font variant code to OpenJK and thought: for consistency I should add it to MP and SP. So I am the one who stepped into that trap of horrible SP font handling. Had I realized there is even magic numbers in the cgame module of SP I might have left out the SP support to avoid corner cases like this and just put a warning comment into the pull request. Now I am trying to fix what I broke.