search

JACoders / OpenJK

Community effort to maintain and improve Jedi Academy (SP & MP) + Jedi Outcast (SP only) released by Raven Software
GNU General Public License v2.0
2.01k stars 612 forks source link

[Linux, OS X] Cannot change brightness #172

Closed KaldNL closed 11 years ago

KaldNL commented 11 years ago

When using the native Linux and OS X OpenJK clients, adjusting the brightness slider does nothing. r_gamma also doesn't work.

This is both windowed and fullscreen.

shinyquagsire23 commented 11 years ago

I can confirm this. I'm guessing that this is an issue with the SDL renderer, but I believe (don't hold me to my word on this though) that gamma correction was meant for older monitors or graphics cards that skewed the colors on games and stuff. On normal brightness for me it looks spectacular.

KaldNL commented 11 years ago

As for it looking fine, it depends on the map. Dark maps like mp/duel1 and mp/ffa2 are a bit too dark to be played properly without setting r_overrbrightbits to 1. However, "bright" maps like mp/ffa3 do look excellent.

shinyquagsire23 commented 11 years ago

It would probably be best to reimplement or add in something to change the brightness using SDL2 I guess. Some maps can be pretty dark, and I do remember in ioquake3 that my old monitor (or maybe graphics card, I replaced both at the same time) couldn't see anything without r_overbrightbits set to 1, so others might face the same issue as well.

redsaurus commented 11 years ago

Should be sorted in 3d639f3d91

KaldNL commented 11 years ago

Works fine.