search

JACoders / OpenJK

Community effort to maintain and improve Jedi Academy (SP & MP) + Jedi Outcast (SP only) released by Raven Software
GNU General Public License v2.0
2.01k stars 612 forks source link

Get rid of the VM #321

Closed archseer closed 11 years ago

archseer commented 11 years ago

as @ensiform said, we should get rid of the VM from the game and use a different import/export system for DLL calls.

Razish commented 11 years ago

Already doing this for MP, it's about 99% done but delayed.

archseer commented 11 years ago

Wow, impressive. SP should be fairly easy, not many calls.

ensiform commented 11 years ago

Did we really need an issue for this when we know I am already working on it.

archseer commented 11 years ago

Yes we did need an issue for this, because it's easier to talk about it and keep track of what's happening. And as we have figured out now, @Razish already started on it, meaning you can just continue where he left off?

ensiform commented 11 years ago

Except no, and all of us on IRC already knew beside you apparently that he was doing MP.

cadika-orade commented 11 years ago

IRC != Documentation

And besides, some people aren't able to connect to the IRC.

deepy commented 11 years ago

No excuses acceptable, there are plenty of ways for people to connect to IRC.

The ones that really cannot connect generally have no way of reaching Github either, use Mibbit or similar last-resorts if need.

cadika-orade commented 11 years ago

Well, I'm so sorry I'm busy getting a master's degree and can't keep a browser widow open 24/7 to watch you guys gossip.

I love following this project and poking around the code to try to make my own changes, but it isn't exactly important enough for me to dedicate my life to watching your instant messages.

There's also no excuse for trying to claim IRC is development documentation. If you worked as a programmer professionally, you'd understand why.

eezstreet commented 11 years ago

If people can't connect to IRC in 2013, then they seriously need to upgrade from potato router or learn how to Google. Or click the Tiramisu link. However I do agree. It isn't wise to make decisions over IRC or explicitly document something over IRC. That being said though, killing off the VM is probably a good idea, as long as you leave in legacy support. The way SP does it is a pretty good example of how it should be handled, with a GetAPI function. Reasons for killing it off are simple: removes a ton of overhead and improves performance quite a bit. Also, it's an easier system to use.

Sent from my Windows Phone

From: cadika-orademailto:notifications@github.com Sent: ‎7/‎14/‎2013 1:18 PM To: Razish/OpenJKmailto:OpenJK@noreply.github.com Subject: Re: [OpenJK] Get rid of the VM (#321)

IRC != Documentation

And besides, some people aren't able to connect to the IRC.

Reply to this email directly or view it on GitHub: https://github.com/Razish/OpenJK/issues/321#issuecomment-20940869

deepy commented 11 years ago

As a matter of fact I am working as a programmer professionally, but what I'm saying is that there's always a way to connect to IRC.

I'm not saying it's documentation.

cadika-orade commented 11 years ago

Well, sorry, but I get a security warning when connecting from my university because they block all things IRC. Also, following the links from my apartment never finishes loading after 3 hours, probably because I can't afford decent Internet because I am a freaking student running on a Windows XP laptop with 1.5GB RAM, which is why I still play JA.

archseer commented 11 years ago

The issue system is not here to replace the IRC, however it is a way to publicly keep track of things, like works in progress. Not all people are online on IRC at the same time, and sometimes it's useful to have a place where you can leave your comments to be read later, or check back onto something that was discussed a while back.

eezstreet commented 11 years ago

I do not like, however, getting 36 emails in a 6 hour period because of the issue system. So let's get back to the topic at hand here.

Sent from my Windows Phone

From: Blaž Hrastnikmailto:notifications@github.com Sent: ‎7/‎14/‎2013 2:23 PM To: Razish/OpenJKmailto:OpenJK@noreply.github.com Cc: eezstreetmailto:eezstreet@live.com Subject: Re: [OpenJK] Get rid of the VM (#321)

The issue system is not here to replace the IRC, however it is a way to publicly keep track of things, like works in progress. Not all people are online on IRC at the same time, and sometimes it's useful to have a place where you can leave your comments to be read later, or check back onto something that was discussed a while back.

Reply to this email directly or view it on GitHub: https://github.com/Razish/OpenJK/issues/321#issuecomment-20941956

ensiform commented 11 years ago

@eezstreet so turn that off and use the browser notifications or get a phone that has github app.

ensiform commented 11 years ago

Im not sure why a sp only person is chiming in about a comment related to MP being worked on and discussed via IRC which is where all of the people with write access are at. Arch was also informed of it on irc first too.

FWIW, the readme says to use the forums for these kinds of discussions too.

ensiform commented 11 years ago

I have the import export interfaces done but some engine side of things aren't ready and have to replace all of the cgi_ functions in the module.

Razish commented 11 years ago

As for MP, the branch is here https://github.com/Razish/OpenJK/tree/stripqvm

ensiform commented 11 years ago

SP is far more complex because cgame is part of same binary as game code. And currently they only load the cgame part via server code as vm-create(cl) and cgame also uses code from game and vice versa.

xycaleth commented 11 years ago

Completed by @Razish. It even falls back to old QVM if the library doesn't implement the new API for backwards compatibility.