Player's (and NPCs?) with over 100 force points can't absorb force power past 100 FP

[dusty22]

Basically, something I've noticed for a while in SP.

When you play as a character, like Kyle, Luke, etc. that has over 100 total FP, when you use Force Absorb, you can only recover force points from enemy force attacks up to 100 FP, but not any further.

It should be able to go as far as whatever your maximum FP total is, no?

[ensiform]

Changes here will make saves incompatible but it is possible to fix.

[dusty22]

FIX NAOW! Really though? Sounds unusual, it that because it's gameplay related?

[ensiform]

Thats because it means storing max force power in the playerstate which is a save affecting field. Its not like you can normally play as someone with higher force max without cheating. :)

[eezstreet]

Isn't max force power already stored in the playerState?

Sent from my Windows Phone

---

From: Ensiformmailto:notifications@github.com Sent: ‎9/‎3/‎2013 2:25 PM To: Razish/OpenJKmailto:OpenJK@noreply.github.com Subject: Re: [OpenJK] Player's (and NPCs?) with over 100 force points can't absorb force power past 100 FP (#370)

Thats because it means storing max force power in the playerstate which is a save affecting field.

---

Reply to this email directly or view it on GitHub: https://github.com/Razish/OpenJK/issues/370#issuecomment-23735456

[ensiform]

Not in SP :/ or maybe it is hm. Does > 100 show up in the hud?

[redsaurus]

yeah it does show up

[eezstreet]

Where is that value stored, then?

Sent from Windows Mail

From: Ensiform Sent: ‎September‎ ‎3‎, ‎2013 ‎2‎:‎35‎ ‎PM To: Razish/OpenJK CC: eezstreet Subject: Re: [OpenJK] Player's (and NPCs?) with over 100 force points can't absorb force power past 100 FP (#370)

Not in SP :/

— Reply to this email directly or view it on GitHub.

[ensiform]

Well the hardcoded define (100) isn't used in absorb function so will have to look further.

[eezstreet]

I'm almost certain that there's either a ps->forcePowerMax or s->forcePowerMax var.

Sent from my Windows Phone

---

From: Ensiformmailto:notifications@github.com Sent: ‎9/‎3/‎2013 4:56 PM To: Razish/OpenJKmailto:OpenJK@noreply.github.com Cc: eezstreetmailto:eezstreet@live.com Subject: Re: [OpenJK] Player's (and NPCs?) with over 100 force points can't absorb force power past 100 FP (#370)

Well the hardcoded define (100) isn't used in absorb function so will have to look further.

---

Reply to this email directly or view it on GitHub: https://github.com/Razish/OpenJK/issues/370#issuecomment-23740668

[ensiform]

Did you not read updated comment about, its there under PS. but absorb is probably just doing something weird.

[dusty22]

IIRC, if you play as a Jedi.npc or reborn or someone with less force points than 100, I'm pretty sure you can only absorb force points up to 90 or whatever your max is, so there is a working variant of this I believe.

[ensiform]

Found it. Issue exists in MP too, but the force power max isn't networked anyway so its not like clients can have differing force power max and have it be visible.

[ensiform]

I will push the fix later. I ran out of time before work.

[ensiform]

Fixed in 930ebbb.