search

JACoders / OpenJK

Community effort to maintain and improve Jedi Academy (SP & MP) + Jedi Outcast (SP only) released by Raven Software
GNU General Public License v2.0
2.01k stars 612 forks source link

Duel queue exploit #409

Open Razish opened 10 years ago

Razish commented 10 years ago

Gametype: Duel Players: 3 Time limit: 2

Behaviour: Person A hits person B Person A reconnects at ~1m55s, a few seconds before timelimit Person C gets shoved into game, person A is now spectating \ Person C "wins" duel because person B had less health Person B goes to end of queue Person A gets to play again (vs person C)

Expected result: When person C gets shoved into game, the duel should restart.

ensiform commented 10 years ago

It doesn't check that there is any sort of duel in progress, just sees that there isnt enough players in the game, so it adds one again.

Yberion commented 10 years ago

http://www.youtube.com/watch?v=EmbXX9TmbnM

ensiform commented 8 years ago

I'm thinking now that RemoveDuelDrawLoser or AdjustTournamentScores may be part of the issue because of the fact that dealing damage is a precondition for this to happen too. @Yberion @Razish

Yberion commented 8 years ago

Well, the one who leaves the duel should make the other one a winner.

ensiform commented 8 years ago

Not looking for more details of what should happen.