Bespin_undercity glitch in loading screen

[aronkihui]

When I load bespin_undercity I get a glitchy loading screen like this:

[aronkihui]

this glitch dind't happen to me before with a older code. Some one did a "cosmetic" fixed in the loading screen I remember... Is the 1th time that I get a glitch after a code update XD in this project...

[ensiform]

You do realize the readme says to not make JK2 issues :p

[ensiform]

The bug is probably caused by e726d398bc4e12925fe5b7ff940a0db7041c1868

[aronkihui]

Sorry ensiform, I read the readme but how I saw some other issues and fixed in jk2 source before, I want collaborated :3. It's because Im latin man with hot blood you know XD. And Jedi Academy doesn't have any trouble that where I seen. It works great. :+1:

[BSzili]

@aronkihui bespin_undercity has no levelshot, so you get a nice defaultImage.

[Razish]

Just checked the JK2 assets, that is indeed the case.

Perhaps it could fall back to e.g. gfx/menus/unknown_map.jpg or whatever SP uses. Does JK2 have an equivalent??

[BSzili]

JK2 has gfx/art/unknownmap.jpg, but I think a plain black background would be more appropriate. Since the previous map fades to black at the end, the original game displays the stats on a black screen.

[aronkihui]

The problem is that in this map the loading screen isn't a black background like Nard Shada Streets level. Bespin_Undercity gets a glitchy gray background just like the shoot that I uploaded XD. This issue didn't happen before of https://github.com/JACoders/OpenJK/commit/e726d398bc4e12925fe5b7ff940a0db7041c1868 code update.

[ensiform]

What you uploaded is the generic texture missing image.

[aronkihui]

Ok but, why thad glitchy gray image? before I was getting this image: The windows version have the same image I guest. I believe that https://github.com/JACoders/OpenJK/commit/e726d398bc4e12925fe5b7ff940a0db7041c1868 background image manage is a back step instead an improve.

[BSzili]

@aronkihui I explained a few posts before why this happens. If you think that displaying the levelshots instead of a black screen is a step back, then I rest my case.

[aronkihui]

Sorry dude I didn't explain one thing. Before this change (https://github.com/JACoders/OpenJK/commit/e726d398bc4e12925fe5b7ff940a0db7041c1868) I get all the loading background right like the windows version. In all the levels I was getting backgrounds image like this:

After the change, all loading backgrounds work like as before but not bespin_undercity. For that reason I said that the mentioned code change is a step back instead a improve, in my case at least (Mac OS).

[BSzili]

@aronkihui I find it fascinating how you still managed to ignore my explanation on why this happens, and the purpose of the change. I won't go back and forth with you more, so I don't spam the devs inbox with all the notification e-mails.

[aronkihui]

Dude I believe that you don't understand to me XD. Read all the tread. I understand to you perfectly, but ok don't problem : / .

[ensiform]

I believe you didn't understand that we knew the problem as soon as you posted the missing image screenshot. And you didn't have to reiterate the issue when I had already told which it was.

Bespin_undercity does not have a levelshot file, therefore you see what you see. Oversight in turning off the code he did.

@BSzili just turn off the notification emails tbh. I rather just check for notifications when on the web.

[aronkihui]

ooo OK sorry, My english suck... I will take more care when I read. And sorry BSzili.

[aronkihui]

Well I fixed this issue reverting manually the change made on codeJK2/cgame/cg_info.cpp (https://github.com/JACoders/OpenJK/commit/e726d398bc4e12925fe5b7ff940a0db7041c1868). Now, the backgrounds work perfect in all the levels:

Bespin_undercity:

Others:

Now in bespin_undercity I get the correct black screen instead the glitchy gray and ugly screen... I still without understand what the hell fix the change https://github.com/JACoders/OpenJK/commit/e726d398bc4e12925fe5b7ff940a0db7041c1868... it only causes an issue in bespin_undercity.

[aronkihui]

Im going to do a push request...

[ensiform]

It's not "glitchy gray" It's the same thing when you try to call any drawing of textures when said texture does not exist.

Rather wait for @BSzili to fix it.

[aronkihui]

Ok. The last question... before https://github.com/JACoders/OpenJK/commit/e726d398bc4e12925fe5b7ff940a0db7041c1868 how OpenJO shows you the loading screens? only for curiosity. I understood that anyone was watching black background always in the load screens.

[ensiform]

It attempts to find a screenshot embeded (disabled i think) or use information from the GPU about what was on the screen if it didn't find the levelshot, or if you loaded a save.

[aronkihui]

To strange XD that never happens to me.

[BSzili]

@aronkihui You keep claiming that you don't understand what did commit fix. The commit message says everyhing: [JK2SP] Show the levelshot when loading a saved game. Of course it won't make sense if you don't read the commit message, and I'll look like some evil mindermast, deliberately breaking things.

[ensiform]

@aronkihui i was describing what it does before. Its how it shows up black before.

[aronkihui]

Sorry I undertand now ensiform, I didn't know ass well the mining of "attempts" but now yes. I read https://github.com/JACoders/OpenJK/commit/e726d398bc4e12925fe5b7ff940a0db7041c1868 change-log before that I open this tread. BSzili I surrender

[aronkihui]

Ensiform in all others levels did you watch a black screen before the https://github.com/JACoders/OpenJK/commit/e726d398bc4e12925fe5b7ff940a0db7041c1868 changes?

[ensiform]

Bespin under city is the only map missing a level shot file.