search

JACoders / OpenJK

Community effort to maintain and improve Jedi Academy (SP & MP) + Jedi Outcast (SP only) released by Raven Software
GNU General Public License v2.0
2.01k stars 612 forks source link

Lighting messed up in mission select #636

Closed Rezzy-dev closed 9 years ago

Rezzy-dev commented 9 years ago

It seems the lighting source is incorrectly moving around on Luke and Kyle on the mission select screens, in the communications window.

The light in the original game seems to have a direct overhead position, while in OpenJK it is radically jumping around, causing strange shadow effects on the faces.

Discussion, screenshots, and details here: http://jkhub.org/topic/5441-mystery-shadow/

xycaleth commented 9 years ago

I suspect it's to do with this line here: https://github.com/JACoders/OpenJK/blob/master/code/ui/ui_shared.cpp#L7231

@Cerezk Can you try replacing that line with:

ent.renderfx = RF_NOSHADOW;

And see if you still get the issue.

That's what the line was originally before any changes.

Rezzy-dev commented 9 years ago

Yes! That's it. That's what was messing up the lighting/shadows in the communications window. I can confidently confirm that this fix works indeed. It is now behaving correctly. Thank you!