Server recommends setting snaps unnecessarily

[Caelish]

I run the JKA servers I host mostly at 50 sv_fps. When connecting, the "Recommend setting /snaps 50 or higher to match this server's sv_fps" message is displayed to clients with <50 snaps, even if sv_snapsmin and sv_snapsmax are both 50. At that point, setting snaps is entirely pointless and does nothing. Very minor issue, but I've seen it cause enough confusion to be annoying. Would be nice for it to display the message only if sv_snapsmin isn't the same as sv_fps (and there's thus any effect from setting snaps)

[ensiform]

Investigating the message as I have seen it before. But I think it might be because of userinfo transmission or lacking causing the message appearing which cannot do a lot about if that is the case.

[Razish]

I don't recall if sv_snapsMin/Max is broadcast to clients, and I think the warning is in JA++(/OpenJK) gamecode?

[Caelish]

I'm not sure. It seems to live over here after some searching: https://github.com/JACoders/OpenJK/blob/0e30710fa7208e2cfe012ccbec3f691c54b02a27/codemp/game/g_client.c#L2317-L2319

[Razish]

o rite, I guess we should delay that. Something like 2s after first spawn..?

[Caelish]

Well that'd make the message more prominent, but that doesn't really seem like a plus to me when it's being spat out in a case where it ideally shouldn't appear at all.

[ensiform]

You'd have to enter the current value into the message just to see why it's showing up.

[ensiform]

The whole point of the message is so that players actually use the sv_fps value for snaps though, is it not? Hence why its a recommendation.

[Caelish]

I think honestly the recommendation is sound, but expecting the client to set their snaps rather than expecting the server to set their sv_snapsmin & sv_snapsmax is backwards, especially when you consider how many different sv_fps values are used. Relying on the user to constantly change a cvar based on the server they visit seems very user unfriendly when sv_snapsmin & sv_snapsmax exist.

Again though, my main issue is the message shows up when sv_snapsmin and sv_snapsmax are already set. One reason is because some players don't understand sv_fps, so not displaying that message would prevent a lot of unfounded complaints.

Since I started using sv_fps 50 by default on servers I host, some of the complaints I've seen (from random players; not my customers) include: -sv_fps must be 20 on JA+ servers or "things get weird" -sv_fps over 30 "is the same as enabling lagunlocker" -sv_fps over 30 causes saber ghosting "because it's too fast for JKA" -Setting snaps to 50 when sv_fps is 50 "is cheating" -sv_fps should be 30 to improve ping, other values will worsen it

...etc etc etc. I don't have the time or energy to lay all those complaints to rest so long as they're not coming from my customers, and being able to suppress that message would be hugely beneficial to my sanity. I already set sv_snapsmin and sv_snapsmax, making the message redundant. In my case, the only thing the message does is draw attention to a cvar many players don't understand, causing FUD and headaches for all involved. Plus wasting 5 seconds of players' time as they set snaps to the value it was already being forced to by sv_snapsmin anyway.

[Razish]

My preference is to remove all of that and just force snaps = sv_fps on the server. But yeah, muh lagunlocker.

[Caelish]

^This sounds like the best option to me. I can think of no reason you wouldn't snaps to be the same as sv_fps, and this solves the problem of player confusion as well as server owners not knowing sv_snapsmin and sv_snapsmax exist.

EDIT: Though maybe make sure not to force snaps = sv_fps over 1000 sv_fps or something, to avoid doing potential Bad Things™ to clients.