search

JACoders / OpenJK

Community effort to maintain and improve Jedi Academy (SP & MP) + Jedi Outcast (SP only) released by Raven Software
GNU General Public License v2.0
2.01k stars 612 forks source link

Endianess Functions use platform-dependent int-types #756

Closed mrwonko closed 6 years ago

mrwonko commented 8 years ago 
short ShortSwap( short l );
int LongSwap( int l );

That should be int16_t/int32_t. It would also be nicer to use inline functions instead of defines for LittleShort etc. The swapping could also be generalized using a template, but that may have to wait until the mp libraries are C++?

This is mostly a note to myself; I'm just too busy to do this right away. (Because I'd like to do it cleanly, and that takes time.)

ensiform commented 8 years ago

This is mostly a note to myself; I'm just too busy to do this right away. (Because I'd like to do it cleanly, and that takes time.)

Wouldn't these make more sense in a mental note document on google or something? =p

mrwonko commented 8 years ago

Wouldn't these make more sense in a mental note document on google or something? =p

I don't see how this is not an issue with OpenJK.

RostakaGmfun commented 8 years ago

I'm currently working on this, PR will be opened ASAP. Please assign this to me.

bmwalters commented 7 years ago

This was fixed by #856, no?

xycaleth commented 6 years ago

Looks like it!