JACoders / OpenJK

Community effort to maintain and improve Jedi Academy (SP & MP) + Jedi Outcast (SP only) released by Raven Software
GNU General Public License v2.0
2.01k stars 612 forks source link

JK2SP Fails to build (missing include) with gcc 5.x #767

Closed Civil closed 8 years ago

Civil commented 8 years ago

Subj. Sorry I'm unable to test it with other versions of gcc, cause I'm using 5.3 atm. Also from my point of view it's not a gcc-related bugs (maybe except one).

See: https://github.com/JACoders/OpenJK/pull/766

Example of errors:

/home/civil/src/OpenJK-civil/codeJK2/game/genericparser2.cpp:183:1: error: ‘CTextPool’ does not name a type
 CTextPool::CTextPool(int initSize) :
/home/civil/src/OpenJK-civil/codeJK2/game/genericparser2.cpp:206:7: error: prototype for ‘char* CTextPool::AllocText(const char*, bool, CTextPool**)’ does not match any in class ‘CTextPool’
 char *CTextPool::AllocText(const char *text, bool addNULL, CTextPool **poolPtr)
       ^
In file included from /home/civil/src/OpenJK-civil/codeJK2/game/genericparser2.cpp:28:0:
/home/civil/src/OpenJK-civil/codeJK2/game/genericparser2.h:66:9: error: candidate is: char* CTextPool::AllocText(char*, bool, CTextPool**)
  char  *AllocText(char *text, bool addNULL = true, CTextPool **poolPtr = 0);
In file included from /home/civil/src/OpenJK-civil/codeJK2/cgame/FX_ATSTMain.cpp:27:0:
/home/civil/src/OpenJK-civil/codeJK2/cgame/FxScheduler.h:304:17: error: ‘CGPGroup’ has not been declared
  bool ParseRGB( CGPGroup *grp );
                 ^
ensiform commented 8 years ago

JK2 fails to build period, regardless of the compiler. See comments on https://github.com/JACoders/OpenJK/commit/b11d6dde1fe37c644c4d2bf9a4cffc1b6cb55373

Won't accept your PR because the changes to the parser will get ported at some point instead.

Civil commented 8 years ago

So your idea is to unify parser between JK2 and JA, right?

mrwonko commented 8 years ago

Yeah, I modernized the parser for JA and did not test my changes with JK2; this will be corrected at some point.