Open Civil opened 8 years ago
Not seeing meaningful crash info there.
The destructor for that class is default and it appears to be calling free from within stl itself.
That would indicate to me that there's some code in the game that's writing outside of bounds.
Very likely
Well yeah, most likely. But credits are 100% way to reproduce this. I'll try to get some info from valgrind or fsantizie=memory
Well, Clang's address sanitizer shows this (multiple runs with some fixes after each), cause it aborts after first bug. It's really huge list, so I've pasted it to my gist: https://gist.github.com/Civil/1db9fb2fa25d5af8dc04
I haven't analized most of them (just added attirbute to ignore memory sanitizer to the function) but: 1 and 2. Looks valid, pMemory is actually NULL and you are not checking for it 3 and 4 Don't actually understand where it comes from
Sorry, I just realized that I've wrote "titles" instead of "Credits".
With valgrind I've got basically the same output.
Oh, forgot to add that VM_DllSyscall
(code/client/vmachine.cpp) must to be declared with __attribute__((no_sanitize_address))
because it do strange stuff with stack and it's 99.99% false-positive.
I'll also update list of complains to address sanitizer. Cause I've just found one more.
I've updated it. Found another one invalid read. And it's also valid. https://gist.github.com/Civil/1db9fb2fa25d5af8dc04/revisions
Looks like I'll need to create a new branch in my fork and fix all memory errors I've found (mostly reading beyond memory) that I was able to fix...
Happens in JA and JO all the time after killing final boss and skipping cinematics.