JACoders / OpenJK

Community effort to maintain and improve Jedi Academy (SP & MP) + Jedi Outcast (SP only) released by Raven Software
GNU General Public License v2.0
2.01k stars 612 forks source link

Option to emulate basejka when fs_game is empty #806

Closed Caelish closed 8 years ago

Caelish commented 8 years ago

So right now, when you run an OpenJK server with fs_game "", you'll have something that's essentially a base server. Here's the thing: when requesting server info in the server browser, it'll tell you the game name is "OpenJK" - as we all know, no true Scotsman base server would ever have a game name saying "OpenJK", and clearly this means it's wildly different in gameplay, damages, and other things that make me a sad cynical Caelum.

But seriously, I've had several customers request an option to set game name to "basejka" so they wouldn't be hassled about it, and I wouldn't say it's an unreasonable concern people will be silly about it. Having a cvar to toggle between the two would be kind of nice to have.

ensiform commented 8 years ago

What? Empty fs_game cvar is base unless you've installed the openjk pk3 in base folder which is exactly what is happening. If you want to run base, don't run OpenJK (mod) in the base folder.

Caelish commented 8 years ago

Not fs_game.

him

^I'd like to change that text from "OpenJK" to "basejka" while still running OpenJK.

ensiform commented 8 years ago

It has nothing to do with running OpenJK.

It has everything to do with using openjk.pk3 This value is set in the jampgame, so no, they aren't running base.

Changing that is unethical because it no longer is actually base.

Caelish commented 8 years ago

I disagree strongly, there's clearly a demand for it (based on several people asking me), and there's clearly a segment of JKA players who wrongly believe OpenJK vastly changes damages/blocks/what-have-you; I feel if server owners want to hide the fact that they're running OpenJK while still getting the benefits of using it, that should be their choice to make. That said, 's not my decision, so fair enough.

xycaleth commented 8 years ago

Does setting fs_gameto "" load the basejka DLLs? I would have thought that if the basejka DLLs are loaded, then the game name would be basejka.

Changing that is unethical because it no longer is actually base.

@ensiform I think you mean misleading, not unethical :P

ensiform commented 8 years ago

The game name variable comes from the jampgame GAMEVERSION macro.

The only time this would occur is if the non base dlls are in base I would think?

AlexCS1337 commented 8 years ago

You guys can just do +set gamename "basejka" in your server start script, I like to do +set gamename "hackedjka" haha

ensiform commented 8 years ago

That won't work. The gamename cvar is marked as cvar_ROM therefore you can't set it at all at the console including startup.

If it worked in jampded that was an exploitable bug which was fixed a long time ago with openjk.

AlexCS1337 commented 8 years ago

Oh my bad, didn't realise that it's an exploit lol