search

JDSherbert / Sherbert-Engine

Custom game engine written in C++ and implementing various middleware.
MIT License
4 stars 3 forks source link

Consider adding `fa-solid-900` font to resources #30

Closed VerzatileDev closed 9 months ago

VerzatileDev commented 9 months ago

Problem

Currently the Engine is using a relative path for the font from the root directory and it is not included to the TargetDir as the folder structure, meaning the program cannot find the specified files.

Area of the issue #define FONT_ICON_FILE_NAME_FAS "Include\\IconFontCppHeaders\\fa-solid-900.ttf" used for both the Debugger local, and the build.

image

The following file: https://github.com/JDSherbert/Sherbert-Engine/blob/main/SherbertEngine/Include/IconFontCppHeaders/fa-solid-900.ttf

Solution

Move the files to Resources, which can be addressed with the following issues https://github.com/JDSherbert/Sherbert-Engine/pull/24

Benefits from having to include the entire include folder separately to use it.

Alternatives

Modify the location of the resource so that it can instead be built into a binary files and looked from there, instead of relative bath.

VerzatileDev commented 9 months ago

Addressed in https://github.com/JDSherbert/Sherbert-Engine/pull/34 and https://github.com/JDSherbert/Sherbert-Engine/pull/36