search

JDimproved / JDim

2ch browser for linux
https://jdimproved.github.io/JDim/
GNU General Public License v2.0
46 stars 11 forks source link

skeleton: Add const qualifier to pointer variables in local scope #1235

Closed ma8ma closed 1 year ago

ma8ma commented 1 year ago

ローカルのポインター変数にconstを付けられるとcppcheckに指摘されたため修正します。

cppcheck 2.11.1のレポート

src/skeleton/dragnote.cpp:337:25: style: Variable 'tablabel' can be declared as pointer to const [constVariablePointer]
    SKELETON::TabLabel* tablabel = m_notebook_tab.get_tablabel( page );
                        ^
src/skeleton/tabnote.cpp:177:29: style: Variable 'tab' can be declared as pointer to const [constVariablePointer]
        SKELETON::TabLabel* tab = get_tablabel( i );
                            ^
src/skeleton/tabnote.cpp:214:25: style: Variable 'tablabel' can be declared as pointer to const [constVariablePointer]
    SKELETON::TabLabel* tablabel = get_tablabel( page );
                        ^
src/skeleton/tabnote.cpp:544:29: style: Variable 'tab' can be declared as pointer to const [constVariablePointer]
        SKELETON::TabLabel* tab = get_tablabel( page );
                            ^
src/skeleton/admin.cpp:354:29: style: Variable 'view' can be declared as pointer to const [constVariablePointer]
            SKELETON::View* view = dynamic_cast< SKELETON::View* >( m_notebook->get_nth_page( i ) );
                            ^
src/skeleton/admin.cpp:1305:25: style: Variable 'view' can be declared as pointer to const [constVariablePointer]
        SKELETON::View* view = dynamic_cast< View* >( m_notebook->get_nth_page( page ) );
                        ^
src/skeleton/admin.cpp:1347:25: style: Variable 'view' can be declared as pointer to const [constVariablePointer]
        SKELETON::View* view = dynamic_cast< View* >( m_notebook->get_nth_page( page ) );
                        ^
src/skeleton/admin.cpp:1528:29: style: Variable 'newview' can be declared as pointer to const [constVariablePointer]
            SKELETON::View* newview = dynamic_cast< View* >( m_notebook->get_nth_page( page + 1 ) );
                            ^
src/skeleton/admin.cpp:1606:25: style: Variable 'view' can be declared as pointer to const [constVariablePointer]
        SKELETON::View* view = dynamic_cast< View* >( m_notebook->get_nth_page( i ) );
                        ^
src/skeleton/admin.cpp:1621:21: style: Variable 'view' can be declared as pointer to const [constVariablePointer]
    SKELETON::View* view = get_current_view();
                    ^
src/skeleton/admin.cpp:1681:25: style: Variable 'view' can be declared as pointer to const [constVariablePointer]
        SKELETON::View* view = get_current_view();
                        ^
src/skeleton/admin.cpp:1699:25: style: Variable 'view' can be declared as pointer to const [constVariablePointer]
        SKELETON::View* view = get_current_view();
                        ^
src/skeleton/admin.cpp:1726:25: style: Variable 'view' can be declared as pointer to const [constVariablePointer]
        SKELETON::View* view = get_current_view();
                        ^
src/skeleton/admin.cpp:1747:25: style: Variable 'view' can be declared as pointer to const [constVariablePointer]
        SKELETON::View* view = get_current_view();
                        ^
src/skeleton/admin.cpp:2082:21: style: Variable 'view' can be declared as pointer to const [constVariablePointer]
    SKELETON::View* view = get_current_view();
                    ^
src/skeleton/admin.cpp:2162:21: style: Variable 'view' can be declared as pointer to const [constVariablePointer]
    SKELETON::View* view = dynamic_cast< View* >( m_notebook->get_nth_page( page ) );
                    ^
src/skeleton/admin.cpp:2217:21: style: Variable 'view' can be declared as pointer to const [constVariablePointer]
    SKELETON::View* view = dynamic_cast<View*>( m_notebook->get_nth_page( page ) );
                    ^
src/skeleton/admin.cpp:2355:21: style: Variable 'view' can be declared as pointer to const [constVariablePointer]
    SKELETON::View* view =  dynamic_cast< View* >( m_notebook->get_nth_page( m_clicked_page ) );
                    ^
src/skeleton/admin.cpp:2384:21: style: Variable 'view' can be declared as pointer to const [constVariablePointer]
    SKELETON::View* view =  dynamic_cast< View* >( m_notebook->get_nth_page( m_clicked_page ) );
                    ^
src/skeleton/admin.cpp:2406:25: style: Variable 'view' can be declared as pointer to const [constVariablePointer]
        SKELETON::View* view = dynamic_cast< View* >( m_notebook->get_nth_page( i ) );
                        ^
src/skeleton/admin.cpp:2427:25: style: Variable 'view' can be declared as pointer to const [constVariablePointer]
        SKELETON::View* view = dynamic_cast< View* >( m_notebook->get_nth_page( i ) );
                        ^
src/skeleton/admin.cpp:2450:25: style: Variable 'view' can be declared as pointer to const [constVariablePointer]
        SKELETON::View* view = dynamic_cast< View* >( m_notebook->get_nth_page( i ) );
                        ^
src/skeleton/admin.cpp:2476:29: style: Variable 'view' can be declared as pointer to const [constVariablePointer]
            SKELETON::View* view = dynamic_cast< View* >( m_notebook->get_nth_page( i ) );
                            ^
src/skeleton/admin.cpp:2527:25: style: Variable 'view' can be declared as pointer to const [constVariablePointer]
        SKELETON::View* view = dynamic_cast< View* >( m_notebook->get_nth_page( i ) );
                        ^
src/skeleton/admin.cpp:2533:25: style: Variable 'view' can be declared as pointer to const [constVariablePointer]
        SKELETON::View* view = dynamic_cast< View* >( m_notebook->get_nth_page( i ) );
                        ^
src/skeleton/admin.cpp:2579:25: style: Variable 'view' can be declared as pointer to const [constVariablePointer]
        SKELETON::View* view = dynamic_cast< View* >( m_notebook->get_nth_page( i ) );
                        ^
src/skeleton/admin.cpp:2587:25: style: Variable 'view' can be declared as pointer to const [constVariablePointer]
        SKELETON::View* view = dynamic_cast< View* >( m_notebook->get_nth_page( i ) );
                        ^
src/skeleton/admin.cpp:2601:25: style: Variable 'view' can be declared as pointer to const [constVariablePointer]
        SKELETON::View* view = dynamic_cast< View* >( m_notebook->get_nth_page( i ) );
                        ^
src/skeleton/admin.cpp:2618:21: style: Variable 'view' can be declared as pointer to const [constVariablePointer]
    SKELETON::View* view =  dynamic_cast< View* >( m_notebook->get_nth_page( m_clicked_page ) );
                    ^
src/skeleton/admin.cpp:2628:21: style: Variable 'view' can be declared as pointer to const [constVariablePointer]
    SKELETON::View* view =  dynamic_cast< View* >( m_notebook->get_nth_page( m_clicked_page ) );
                    ^
src/skeleton/admin.cpp:2640:21: style: Variable 'view' can be declared as pointer to const [constVariablePointer]
    SKELETON::View* view =  dynamic_cast< View* >( m_notebook->get_nth_page( m_clicked_page ) );
                    ^
src/skeleton/admin.cpp:2678:21: style: Variable 'view' can be declared as pointer to const [constVariablePointer]
    SKELETON::View* view =  dynamic_cast< View* >( m_notebook->get_nth_page( page ) );
                    ^
src/skeleton/admin.cpp:2686:21: style: Variable 'view' can be declared as pointer to const [constVariablePointer]
    SKELETON::View* view =  dynamic_cast< View* >( m_notebook->get_nth_page( page ) );
                    ^
src/skeleton/admin.cpp:2694:21: style: Variable 'view' can be declared as pointer to const [constVariablePointer]
    SKELETON::View* view = get_view( url );
                    ^
src/skeleton/admin.cpp:2721:21: style: Variable 'view' can be declared as pointer to const [constVariablePointer]
    SKELETON::View* view = get_view( url );
                    ^
src/skeleton/admin.cpp:2747:21: style: Variable 'view' can be declared as pointer to const [constVariablePointer]
    SKELETON::View* view =  dynamic_cast< View* >( m_notebook->get_nth_page( m_clicked_page ) );
                    ^
src/skeleton/admin.cpp:2768:21: style: Variable 'view' can be declared as pointer to const [constVariablePointer]
    SKELETON::View* view =  dynamic_cast< View* >( m_notebook->get_nth_page( m_clicked_page ) );
                    ^
src/skeleton/admin.cpp:2788:21: style: Variable 'view' can be declared as pointer to const [constVariablePointer]
    SKELETON::View* view = get_view( url );
                    ^
src/skeleton/admin.cpp:2955:25: style: Variable 'view' can be declared as pointer to const [constVariablePointer]
        SKELETON::View* view = get_view( url );
                        ^