JDimproved / JDim

2ch browser for linux
https://jdimproved.github.io/JDim/
GNU General Public License v2.0
44 stars 11 forks source link

LinkFilterDiag: Rename member function to avoid conflict with parent member #1263

Closed ma8ma closed 10 months ago

ma8ma commented 10 months ago

親クラスのメンバー関数と名前が重複しているとcppcheckに指摘されたため子クラスのメンバー関数の名前を変更します。

cppcheck 2.12.1のレポート

src/linkfilterpref.h:29:23: warning: The class 'LinkFilterDiag' defines member function with name 'get_url' also defined in its parent class 'PrefDiag'. [duplInheritedMember]
        Glib::ustring get_url() const { return m_entry_url.get_text(); }
                      ^
src/skeleton/prefdiag.h:32:28: note: Parent function 'PrefDiag::get_url'
        const std::string& get_url() const { return m_url; }
                           ^
src/linkfilterpref.h:29:23: note: Derived function 'LinkFilterDiag::get_url'
        Glib::ustring get_url() const { return m_entry_url.get_text(); }
                      ^