JDimproved / JDim

2ch browser for linux
https://jdimproved.github.io/JDim/
GNU General Public License v2.0
44 stars 11 forks source link

Board2ch: Get rid of useless override member functions #1270

Closed ma8ma closed 9 months ago

ma8ma commented 9 months ago

親クラスのメンバー関数を呼び出しているだけのメンバー関数があるとcppcheckに指摘されたため子クラスのメンバーを整理します。

cppcheck 2.12.1のレポート

src/dbtree/board2ch.h:64:21: style: The function 'url_bbscgi_new' overrides a function in a base class but just delegates back to the base class. [uselessOverride]
        std::string url_bbscgi_new() const override;
                    ^
src/dbtree/board2chcompati.h:45:21: note: Virtual function in base class
        std::string url_bbscgi_new() const override;
                    ^
src/dbtree/board2ch.h:64:21: note: Function in derived class
        std::string url_bbscgi_new() const override;
                    ^
src/dbtree/board2ch.h:67:21: style: The function 'url_subbbscgi_new' overrides a function in a base class but just delegates back to the base class. [uselessOverride]
        std::string url_subbbscgi_new() const override;
                    ^
src/dbtree/board2chcompati.h:48:21: note: Virtual function in base class
        std::string url_subbbscgi_new() const override;
                    ^
src/dbtree/board2ch.h:67:21: note: Function in derived class
        std::string url_subbbscgi_new() const override;
                    ^