search

JDimproved / JDim

2ch browser for linux
https://jdimproved.github.io/JDim/
GNU General Public License v2.0
44 stars 11 forks source link

Fix compiler warnings for -Wsuggest-destructor-override part1 #1290

Closed ma8ma closed 8 months ago

ma8ma commented 8 months ago

オーバーライドしたデストラクタにoverrideキーワードが付いていないと コンパイラーに指摘されたため修正します。

clang-17のレポート (file pathを一部省略)

src/history/historymenu.h:24:9: warning: '~HistoryMenu' overrides a destructor but is not marked 'override' [-Wsuggest-destructor-override]
src/history/historysubmenu.h:29:9: warning: '~HistorySubMenu' overrides a destructor but is not marked 'override' [-Wsuggest-destructor-override]
src/jdlib/imgloader.h:42:17: warning: '~ImgLoader' overrides a destructor but is not marked 'override' [-Wsuggest-destructor-override]
src/message/toolbar.h:24:9: warning: '~MessageToolBarBase' overrides a destructor but is not marked 'override' [-Wsuggest-destructor-override]
src/message/toolbar.h:55:9: warning: '~MessageToolBar' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override]
src/message/toolbar.h:79:9: warning: '~MessageToolBarPreview' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override]
src/skeleton/dragnote.h:113:9: warning: '~DragableNoteBook' overrides a destructor but is not marked 'override' [-Wsuggest-destructor-override]
src/skeleton/editcolumns.h:52:9: warning: '~EditColumns' overrides a destructor but is not marked 'override' [-Wsuggest-destructor-override]
src/skeleton/jdtoolbar.h:21:9: warning: '~JDToolbar' overrides a destructor but is not marked 'override' [-Wsuggest-destructor-override]
src/skeleton/msgdiag.h:36:9: warning: '~MsgDiag' overrides a destructor but is not marked 'override' [-Wsuggest-destructor-override]
src/skeleton/msgdiag.h:69:9: warning: '~MsgCheckDiag' overrides a destructor but is not marked 'override' [-Wsuggest-destructor-override]
src/skeleton/msgdiag.h:91:9: warning: '~MsgOverwriteDiag' overrides a destructor but is not marked 'override' [-Wsuggest-destructor-override]
src/skeleton/prefdiag.h:30:9: warning: '~PrefDiag' overrides a destructor but is not marked 'override' [-Wsuggest-destructor-override]
src/skeleton/tabswitchbutton.h:27:9: warning: '~TabSwitchButton' overrides a destructor but is not marked 'override' [-Wsuggest-destructor-override]
src/skeleton/toolbar.h:78:9: warning: '~ToolBar' overrides a destructor but is not marked 'override' [-Wsuggest-destructor-override]
src/skeleton/toolbarnote.h:21:9: warning: '~ToolBarNotebook' overrides a destructor but is not marked 'override' [-Wsuggest-destructor-override]
src/skeleton/vbox.h:18:9: warning: '~JDVBox' overrides a destructor but is not marked 'override' [-Wsuggest-destructor-override]
src/skeleton/view.h:180:9: warning: '~View' overrides a destructor but is not marked 'override' [-Wsuggest-destructor-override]
src/skeleton/viewnote.h:21:9: warning: '~ViewNotebook' overrides a destructor but is not marked 'override' [-Wsuggest-destructor-override]
src/xml/document.h:33:9: warning: '~Document' overrides a destructor but is not marked 'override' [-Wsuggest-destructor-override]