search

JDimproved / JDim

2ch browser for linux
https://jdimproved.github.io/JDim/
GNU General Public License v2.0
46 stars 11 forks source link

Fix compiler warnings for -Wsuggest-destructor-override part2 #1304

Closed ma8ma closed 9 months ago

ma8ma commented 9 months ago

オーバーライドしたデストラクタにoverrideキーワードが付いていないとコンパイラーに指摘されたため修正します。

clang-17のレポート (file pathを一部省略)

src/article/drawareabase.h:278:9: warning: '~DrawAreaBase' overrides a destructor but is not marked 'override' [-Wsuggest-destructor-override]
src/bbslist/addetcdialog.h:27:9: warning: '~AddEtcDialog' overrides a destructor but is not marked 'override' [-Wsuggest-destructor-override]
src/bbslist/editlistwin.h:29:9: warning: '~EditListWin' overrides a destructor but is not marked 'override' [-Wsuggest-destructor-override]
src/board/columns.h:69:9: warning: '~TreeColumns' overrides a destructor but is not marked 'override' [-Wsuggest-destructor-override]
src/replacestrpref.h:114:9: warning: '~ReplaceStrPref' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override]
src/replacestrpref.h:42:9: warning: '~ReplaceStrDiag' overrides a destructor but is not marked 'override' [-Wsuggest-destructor-override]
src/replacestrpref.h:80:9: warning: '~ReplaceRecord' overrides a destructor but is not marked 'override' [-Wsuggest-destructor-override]
src/setupwizard.h:155:9: warning: '~SetupWizard' overrides a destructor but is not marked 'override' [-Wsuggest-destructor-override]
src/skeleton/aboutdiag.h:51:9: warning: '~AboutDiag' overrides a destructor but is not marked 'override' [-Wsuggest-destructor-override]
src/skeleton/compentry.h:46:9: warning: '~CompletionEntry' overrides a destructor but is not marked 'override' [-Wsuggest-destructor-override]
src/skeleton/editview.h:132:9: warning: '~EditView' overrides a destructor but is not marked 'override' [-Wsuggest-destructor-override]
src/skeleton/editview.h:66:9: warning: '~EditTextView' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override]
src/skeleton/filediag.h:51:9: warning: '~FileDiag' overrides a destructor but is not marked 'override' [-Wsuggest-destructor-override]
src/skeleton/imgtoolbutton.h:35:9: warning: '~ToolButtonExtension' overrides a destructor but is not marked 'override' [-Wsuggest-destructor-override]
src/skeleton/label_entry.h:30:9: warning: '~LabelEntry' overrides a destructor but is not marked 'override' [-Wsuggest-destructor-override]
src/skeleton/login.h:31:9: warning: '~Login' overrides a destructor but is not marked 'override' [-Wsuggest-destructor-override]
src/skeleton/notebook.h:18:9: warning: '~JDNotebook' overrides a destructor but is not marked 'override' [-Wsuggest-destructor-override]
src/skeleton/popupwin.h:33:9: warning: '~PopupWin' overrides a destructor but is not marked 'override' [-Wsuggest-destructor-override]
src/skeleton/tabnote.cpp:30:5: warning: '~DummyWidget' overrides a destructor but is not marked 'override' [-Wsuggest-destructor-override]
src/skeleton/tabswitchmenu.h:33:9: warning: '~TabSwitchMenu' overrides a destructor but is not marked 'override' [-Wsuggest-destructor-override]
src/skeleton/toolmenubutton.h:34:9: warning: '~ToolMenuButton' overrides a destructor but is not marked 'override' [-Wsuggest-destructor-override]