JDimproved / JDim

2ch browser for linux
https://jdimproved.github.io/JDim/
GNU General Public License v2.0
44 stars 11 forks source link

Fix compiler warnings for -Winconsistent-missing-destructor-override part1,2,3 #1305

Closed ma8ma closed 7 months ago

ma8ma commented 7 months ago

Fix compiler warnings for -Winconsistent-missing-destructor-override part1

オーバーライドしたデストラクタにoverrideキーワードが付いていないとコンパイラーに指摘されたため修正します。

clang-17のレポート (file pathを一部省略)

src/config/aboutconfig.h:63:9: warning: '~AboutConfig' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override]
src/control/buttonconfig.h:18:9: warning: '~ButtonConfig' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override]
src/control/keyconfig.h:20:9: warning: '~KeyConfig' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override]
src/control/mouseconfig.h:19:9: warning: '~MouseConfig' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override]
src/dbimg/delimgcachediag.h:29:9: warning: '~DelImgCacheDiag' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override]
src/dbimg/img.h:59:9: warning: '~Img' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override]
src/message/confirmdiag.h:21:9: warning: '~ConfirmDiag' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override]
src/message/messageadmin.h:48:9: warning: '~MessageAdmin' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override]
src/message/messageview.h:15:9: warning: '~MessageViewMain' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override]
src/message/messageview.h:30:9: warning: '~MessageViewNew' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override]
src/message/messageviewbase.h:80:9: warning: '~MessageViewBase' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override]
src/message/messagewin.h:17:9: warning: '~MessageWin' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override]
src/skeleton/admin.h:75:9: warning: '~Admin' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override]
src/skeleton/detaildiag.h:30:9: warning: '~DetailDiag' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override]
src/skeleton/entry.h:36:9: warning: '~JDEntry' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override]
src/skeleton/loadable.h:92:9: warning: '~Loadable' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override]
src/skeleton/popupwinbase.h:33:9: warning: '~PopupWinBase' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override]
src/skeleton/tabnote.h:70:9: warning: '~TabNotebook' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override]
src/skeleton/treeviewbase.h:46:9: warning: '~JDTreeViewBase' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override]
src/sound/playsound.h:60:9: warning: '~Play_Sound' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override]

Fix compiler warnings for -Winconsistent-missing-destructor-override part2

オーバーライドしたデストラクタにoverrideキーワードが付いていないとコンパイラーに指摘されたため修正します。

clang-17のレポート (file pathを一部省略)

src/bbslist/bbslistadmin.h:35:9: warning: '~BBSListAdmin' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override]
src/bbslist/bbslistviewbase.h:193:9: warning: '~BBSListViewBase' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override]
src/bbslist/columns.h:20:9: warning: '~TreeColumns' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override]
src/bbslist/toolbar.h:31:9: warning: '~BBSListToolBar' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override]
src/bbslist/toolbar.h:60:9: warning: '~EditListToolBar' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override]
src/image/imageadmin.h:45:9: warning: '~ImageAdmin' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override]
src/image/imagearea.h:19:9: warning: '~ImageAreaMain' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override]
src/image/imageareabase.h:53:9: warning: '~ImageAreaBase' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override]
src/image/imageareaicon.h:35:9: warning: '~ImageAreaIcon' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override]
src/image/imageareapopup.h:19:9: warning: '~ImageAreaPopup' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override]
src/image/imageview.h:36:9: warning: '~ImageViewMain' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override]
src/image/imageviewbase.h:71:9: warning: '~ImageViewBase' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override]
src/image/imageviewicon.h:21:9: warning: '~ImageViewIcon' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override]
src/image/imageviewpopup.h:28:9: warning: '~ImageViewPopup' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override]
src/image/imagewin.h:23:9: warning: '~ImageWin' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override]
src/message/post.cpp:36:5: warning: '~WriteStrategy' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override]
src/message/post.cpp:49:5: warning: '~NewArticleStrategy' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override]
src/message/post.h:64:9: warning: '~Post' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override]
src/skeleton/dragtreeview.h:71:9: warning: '~DragTreeView' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override]
src/skeleton/edittreeview.h:87:9: warning: '~EditTreeView' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override]

Fix compiler warnings for -Winconsistent-missing-destructor-override part3

オーバーライドしたデストラクタにoverrideキーワードが付いていないとコンパイラーに指摘されたため修正します。

clang-17のレポート (file pathを一部省略)

src/article/articleadmin.h:47:9: warning: '~ArticleAdmin' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override]
src/bbslist/bbslistview.h:19:9: warning: '~BBSListViewMain' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override]
src/bbslist/favoriteview.h:18:9: warning: '~FavoriteListView' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override]
src/bbslist/historyview.h:20:9: warning: '~HistoryViewBase' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override]
src/bbslist/selectdialog.h:39:9: warning: '~SelectListDialog' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override]
src/bbslist/selectlistview.h:26:9: warning: '~SelectListView' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override]
src/board/boardadmin.h:27:9: warning: '~BoardAdmin' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override]
src/board/boardview.h:17:9: warning: '~BoardView' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override]
src/board/boardviewbase.h:112:9: warning: '~BoardViewBase' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override]
src/board/boardviewlog.h:22:9: warning: '~BoardViewLog' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override]
src/board/boardviewnext.h:31:9: warning: '~BoardViewNext' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override]
src/board/boardviewsidebar.h:27:9: warning: '~BoardViewSidebar' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override]
src/board/preference.h:191:9: warning: '~Preferences' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override]
src/board/toolbar.h:19:9: warning: '~BoardToolBar' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override]
src/dbtree/articlebase.h:130:9: warning: '~ArticleBase' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override]
src/dbtree/boardbase.h:267:9: warning: '~BoardBase' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override]
src/jdlib/cookiemanager.cpp:53:5: warning: '~SimpleCookieManager' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override]
src/searchmanager.h:80:9: warning: '~Search_Manager' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override]
src/skeleton/menubutton.h:44:9: warning: '~MenuButton' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override]
src/skeleton/window.h:58:9: warning: '~JDWindow' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override]