JDimproved / JDim

2ch browser for linux
https://jdimproved.github.io/JDim/
GNU General Public License v2.0
44 stars 11 forks source link

Fix compiler warnings for -Winconsistent-missing-destructor-override part4,5,6,7 #1311

Closed ma8ma closed 6 months ago

ma8ma commented 6 months ago

Fix compiler warnings for -Winconsistent-missing-destructor-override part4

オーバーライドしたデストラクタにoverrideキーワードが付いていないとコンパイラーに指摘されたため修正します。

clang-17のレポート (file pathを一部省略) ``` src/article/articleview.h:43:9: warning: '~ArticleViewMain' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override] src/article/articleviewbase.h:97:9: warning: '~ArticleViewBase' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override] src/article/articleviewetc.h:119:9: warning: '~ArticleViewPost' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override] src/article/articleviewetc.h:144:9: warning: '~ArticleViewHighRefRes' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override] src/article/articleviewetc.h:167:9: warning: '~ArticleViewURL' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override] src/article/articleviewetc.h:191:9: warning: '~ArticleViewRefer' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override] src/article/articleviewetc.h:217:9: warning: '~ArticleViewDrawout' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override] src/article/articleviewetc.h:22:9: warning: '~ArticleViewRes' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override] src/article/articleviewetc.h:240:9: warning: '~ArticleViewPostlog' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override] src/article/articleviewetc.h:46:9: warning: '~ArticleViewName' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override] src/article/articleviewetc.h:70:9: warning: '~ArticleViewID' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override] src/article/articleviewetc.h:94:9: warning: '~ArticleViewBM' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override] src/article/articleviewpopup.h:102:9: warning: '~ArticleViewPopupID' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override] src/article/articleviewpopup.h:122:9: warning: '~ArticleViewPopupRefer' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override] src/article/articleviewpopup.h:142:9: warning: '~ArticleViewPopupDrawout' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override] src/article/articleviewpopup.h:159:9: warning: '~ArticleViewPopupBM' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override] src/article/articleviewpopup.h:22:9: warning: '~ArticleViewPopup' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override] src/article/articleviewpopup.h:44:9: warning: '~ArticleViewPopupHTML' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override] src/article/articleviewpopup.h:62:9: warning: '~ArticleViewPopupRes' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override] src/article/articleviewpopup.h:82:9: warning: '~ArticleViewPopupName' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override] ```

Fix compiler warnings for -Winconsistent-missing-destructor-override part5

オーバーライドしたデストラクタにoverrideキーワードが付いていないとコンパイラーに指摘されたため修正します。

clang-17のレポート (file pathを一部省略) ``` src/article/articleviewinfo.h:17:9: warning: '~ArticleViewInfo' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override] src/article/articleviewpreview.h:19:9: warning: '~ArticleViewPreview' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override] src/article/articleviewsearch.h:34:9: warning: '~ArticleViewSearch' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override] src/article/embeddedimage.h:37:9: warning: '~EmbeddedImage' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override] src/article/preference.h:84:9: warning: '~Preferences' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override] src/article/toolbar.h:32:9: warning: '~ArticleToolBar' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override] src/article/toolbarsearch.h:29:9: warning: '~SearchToolBar' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override] src/article/toolbarsimple.h:17:9: warning: '~ArticleToolBarSimple' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override] src/dbtree/article2ch.h:19:9: warning: '~Article2ch' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override] src/dbtree/article2chcompati.h:19:9: warning: '~Article2chCompati' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override] src/dbtree/articlejbbs.h:21:9: warning: '~ArticleJBBS' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override] src/dbtree/articlelocal.h:19:9: warning: '~ArticleLocal' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override] src/dbtree/articlemachi.h:21:9: warning: '~ArticleMachi' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override] src/dbtree/nodetree2ch.h:27:9: warning: '~NodeTree2ch' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override] src/dbtree/nodetree2chcompati.h:29:9: warning: '~NodeTree2chCompati' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override] src/dbtree/nodetreebase.h:161:9: warning: '~NodeTreeBase' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override] src/dbtree/nodetreedummy.h:19:9: warning: '~NodeTreeDummy' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override] src/dbtree/nodetreejbbs.h:32:9: warning: '~NodeTreeJBBS' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override] src/dbtree/nodetreelocal.h:19:9: warning: '~NodeTreeLocal' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override] src/dbtree/nodetreemachi.h:40:9: warning: '~NodeTreeMachi' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override] ```

Fix compiler warnings for -Winconsistent-missing-destructor-override part6

オーバーライドしたデストラクタにoverrideキーワードが付いていないとコンパイラーに指摘されたため修正します。

clang-17のレポート (file pathを一部省略) ``` src/articleitemmenupref.h:17:9: warning: '~ArticleItemMenuPref' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override] src/dbtree/board2ch.h:32:9: warning: '~Board2ch' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override] src/dbtree/board2chcompati.h:28:9: warning: '~Board2chCompati' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override] src/dbtree/boardjbbs.h:28:9: warning: '~BoardJBBS' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override] src/dbtree/boardlocal.h:19:9: warning: '~BoardLocal' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override] src/dbtree/boardmachi.h:19:9: warning: '~BoardMachi' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override] src/dbtree/frontloader.h:27:9: warning: '~FrontLoader' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override] src/dbtree/root.h:84:9: warning: '~Root' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override] src/dbtree/ruleloader.h:27:9: warning: '~RuleLoader' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override] src/dbtree/settingloader.h:42:9: warning: '~SettingLoader' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override] src/login2ch.h:27:9: warning: '~Login2ch' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override] src/loginbe.h:27:9: warning: '~LoginBe' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override] src/skeleton/aamenu.h:34:9: warning: '~AAMenu' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override] src/skeleton/hpaned.h:22:9: warning: '~JDHPaned' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override] src/skeleton/panecontrol.h:103:9: warning: '~HPaneControl' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override] src/skeleton/panecontrol.h:125:9: warning: '~VPaneControl' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override] src/skeleton/selectitempref.h:82:9: warning: '~SelectItemPref' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override] src/skeleton/tablabel.h:52:9: warning: '~TabLabel' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override] src/skeleton/textloader.h:36:9: warning: '~TextLoader' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override] src/skeleton/vpaned.h:22:9: warning: '~JDVPaned' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override] ```

Fix compiler warnings for -Winconsistent-missing-destructor-override part7

オーバーライドしたデストラクタにoverrideキーワードが付いていないとコンパイラーに指摘されたため修正します。

clang-17のレポート (file pathを一部省略) ``` src/articleitempref.h:17:9: warning: '~ArticleItemPref' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override] src/boarditemmenupref.h:17:9: warning: '~BoardItemMenuPref' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override] src/boarditempref.h:17:9: warning: '~BoardItemColumnPref' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override] src/boarditempref.h:33:9: warning: '~BoardItemPref' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override] src/core.h:124:9: warning: '~Core' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override] src/dbimg/delimgdiag.h:121:9: warning: '~DelImgDiag' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override] src/dbtree/bbsmenu.h:57:5: warning: '~BBSMenu' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override] src/fontcolorpref.h:85:9: warning: '~FontColorPref' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override] src/globalabonepref.h:75:9: warning: '~GlobalAbonePref' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override] src/globalabonethreadpref.h:136:9: warning: '~GlobalAboneThreadPref' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override] src/livepref.h:38:9: warning: '~LivePref' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override] src/mainitempref.h:17:9: warning: '~MainItemPref' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override] src/maintoolbar.h:44:9: warning: '~MainToolBar' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override] src/msgitempref.h:17:9: warning: '~MsgItemPref' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override] src/openurldiag.h:22:9: warning: '~OpenURLDialog' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override] src/passwdpref.h:137:9: warning: '~PasswdPref' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override] src/privacypref.h:81:9: warning: '~PrivacyPref' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override] src/proxypref.h:259:9: warning: '~ProxyPref' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override] src/searchitempref.h:17:9: warning: '~SearchItemPref' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override] src/searchloader.h:27:9: warning: '~SearchLoader' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override] src/sidebaritempref.h:17:9: warning: '~SidebarItemPref' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override] src/winmain.h:32:5: warning: '~JDWinMain' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override] ```

関連のpull request: #1305