search

JForsaken / protosketcher-frontend

Protosketcher's frontend application.
0 stars 0 forks source link

Simulation Modal #82

Closed jrainville closed 7 years ago

jrainville commented 7 years ago

For https://github.com/JForsaken/protosketcher-frontend/issues/76 This handles the controls that affect modals. It calls its parent (the simulation) and tells it to create a modal for the specified page. The modal is in fact another Simulation instance containing a flag called isModal and the page id in this.pageId. There are probably cases that are not covered by that PR, example, if there is a page change within the modal, what happens. Those things I haven't tested, but it is going to be easier to review like this and also it works for the basic use case.

JForsaken commented 7 years ago

Sorry for the conflicts @jrainville

jrainville commented 7 years ago

Alright, j'ai rebase et retiré la cute line

jrainville commented 7 years ago

ples @franck36 or @GLatendresse review my shit