escoEstimate.SingleCellExperiment ignores dirname, group, cellinfo

[HelenaLC]

Issue

• I noticed that when running x <- escoEstimate(sce, dirname, group = TRUE, cellinfo = ...) I kept getting 1 from getParam(x, "nGroups")
• in esco-estimate.R, escoEstimate.SingleCellExperiment in fact ignores all parameters except for counts and params

Solution

escoEstimate.SingleCellExperiment <- function(counts, 
    dirname, group = FALSE, cellinfo = NULL, params = newescoParams()) 
{
    counts <- BiocGenerics::counts(counts)
    escoEstimate(counts, params)
}

should be

escoEstimate.SingleCellExperiment <- function(counts, 
    dirname, group = FALSE, cellinfo = NULL, params = newescoParams()) 
{
    counts <- BiocGenerics::counts(counts)
    escoEstimate(counts, dirname, group, cellinfo, params)
}