JaCzekanski / Avocado

🥑 PlayStation 1 emulator
GNU General Public License v2.0
538 stars 31 forks source link

Misc Android updates #73

Closed TacoTheDank closed 4 years ago

TacoTheDank commented 4 years ago
TacoTheDank commented 4 years ago

The CI failed, as I have come to expect.

0.01s$ openssl aes-256-cbc -K $encrypted_7333c7dd5b15_key -iv $encrypted_7333c7dd5b15_iv -in android/avocado.keystore.enc -out android/avocado.keystore -d
iv undefined

The command "openssl aes-256-cbc -K $encrypted_7333c7dd5b15_key -iv $encrypted_7333c7dd5b15_iv -in android/avocado.keystore.enc -out android/avocado.keystore -d" failed and exited with 1 during .

What even...

JaCzekanski commented 4 years ago

Hi, thanks for the pull request. I don't see the point of refactoring the SDL specific code - everything in org/libsdl/app will be overwritten by any future SDL update anyway. That's also the reason why I didn't bother with refactoring to Kotlin in SDL classes - that's additional code I need to maintain.

The CI failed, as I have come to expect.

0.01s$ openssl aes-256-cbc -K $encrypted_7333c7dd5b15_key -iv $encrypted_7333c7dd5b15_iv -in android/avocado.keystore.enc -out android/avocado.keystore -d
iv undefined

The command "openssl aes-256-cbc -K $encrypted_7333c7dd5b15_key -iv $encrypted_7333c7dd5b15_iv -in android/avocado.keystore.enc -out android/avocado.keystore -d" failed and exited with 1 during .

What even...

Don't worry about that - I forgot to disable signing for PR CI builds - keystore is not available there.

TacoTheDank commented 4 years ago

I'll undo the last two commits, then.

TacoTheDank commented 4 years ago

Any updates?

JaCzekanski commented 4 years ago

Sorry, I didn't get any notification about new changes. LGTM