search

Jack477 / CommanderPi

Easy RaspberryPi4 GUI system managment
MIT License
188 stars 33 forks source link

Fix bootloader unknown #28

Closed arelyx closed 3 years ago

arelyx commented 3 years ago

Oops!

Looks like my initial pull request caused an issue on non Pi 4 boards.

I've improved the get_actual_version function further; Instead of splicing the string from vcgencmd bootloader_version, I am just getting the bootloader version from a bash command.

I have tested this on my Pi 4 and Pi 2, everything should be working just fine.

Jack477 commented 3 years ago

Unfortunately I don't have Pi 4 < boards so I can't test it myself. If you sure about path and file format I will push it.

arelyx commented 3 years ago

That's understandable.

Yes, with the previous version I was having the same problem as in issue #27 on my Pi 2. With this new fix, instead of using vcgencmd bootloader_version I used a bash command to just find all of the installed eeproms and select the most recent one.

I've tested this fix on the Pi 2 and the Pi 4 on a clean install and the program installs and runs without issue, so I'm pretty sure the path and file format should be good.