Jack477 / CommanderPi

Easy RaspberryPi4 GUI system managment
MIT License
188 stars 33 forks source link

change start.sh to use SH instead of BASH #32

Closed paulwratt closed 3 years ago

paulwratt commented 3 years ago

(I have other PR's and since this is a one liner ..) The shell startup line in ~/CommanderPi/src/start.sh should be change from:

#!/bin/bash
sudo python3 ${HOME}/CommanderPi/src/main.py ${HOME}> log.txt

to:

#!/bin/sh
sudo python3 ${HOME}/CommanderPi/src/main.py ${HOME}> log.txt

This way it will work on any setup, not just ones that have bash installed.

NOTE: the same should be done with ~/CommanderPi/install.shtoo, as there is nothing BASH specific in that file either. SH is always preferable of BASH for scripts, unless there an explicit need for BASH specific command usage (which there are always known workarounds for anyway)

Jack477 commented 3 years ago

Alright, pushed.