Jack477 / CommanderPi

Easy RaspberryPi4 GUI system managment
MIT License
189 stars 33 forks source link

ENHANCEMENT REQUEST: A few suggestions #5

Closed dikodahan closed 4 years ago

dikodahan commented 4 years ago

First off, thank you for this! Great little app!!!

I just installed on an RPI3B+ with Raspberry Pi OS and it works without issues. A few things I noticed though that are worth fixing:

  1. I would suggest renaming test.desktop to commander-pi.desktop. This will just make it simpler and prevent any potential future conflict because of using the name test.
  2. The desktop file is has a link for the icon as logo.png. The file does not exist. I manually updated it to icon.png and it works without any issues. A quick update to the c_desktop.py file to point to the right file will solve that.
  3. After the creation of the file desktop file in /usr/share/applications/ there is no need to leave the file on the desktop. It can be deleted in the script to keep things clean.

With that, I would also suggest a few enhancements, if I may:

Again, really great small app!!! Just throwing it out there for a few potential enhancements to help others :)

Jack477 commented 4 years ago

Thanks for your request.
I will fix this small things which I missed.

  1. Idea with few simple buttons to overclock is cool, you can expect something like this in near update
  2. I will add annotation about RPI3B+ support
  3. I will add board model on main window
  4. I was thinking about boot configuration, maybe in future who knows
    Honestly I'm new in RPI, I made this app from zero so support like Yours it's very helpfull
dikodahan commented 4 years ago

Awesome! One more comment on this one, since this is going to have frequent updates and additions, I suggest you add a check in code against a version update in the GitHub repo to notify user of a pending update and a click to update (runs a script to close the app, downloads & updates files, relaunch app).