Round Not Moving options

[Jacob-Griffin]

I don't estimate that this will be nearly as big a problem with this version of the game since the player will not start their waiting unless the submit was successful, but there should be a few options if a player disconnects or somehow misses their send and can't get back into the round.

• [x] People should hold onto their most recent round data in local storage. That way if they have to reload, progress can be restored.
• [x] People who closed/lost the tab/window should be able to rejoin their in-progress game (via join menu, some checks should be in place to ensure we aren't getting people jumping onto stacks with active players)
• The host should have some options to proceed with the game. If people are still waiting after the round passes its global end time, the host should probably be able to:
  • Move ahead anyway (Host will insert defaults into the missing player's round)
  • Remove the missing player (The from-to gap will simply be closed, will require some extra logic to make sure the final stacks are assembled correctly despite the dead one)
  • Add extra time (Missing player will be able to get back into gameplay, since their complete state is synced to firebase)

[Jacob-Griffin]

People can rejoin games if their status is 'missing', and they put in their name correctly. Firebase can take a simple handle for onDisconnect, which includes any navigation away from the gameplay page, based on a reference the client passes them (ex. "Here's where my player status is, if I leave for any reason, mark me missing").

The lingering thing that might need some doing is getting your username exactly right on rejoin, but we can include a button specifically for rejoining a broken game, based on info I've stored locally. Edit: I went with making it autofill username and gameid if backed up game data exists

[Jacob-Griffin]

Thinking through this one again, now that rejoining an in progress game is possible

• I don't see the benefit to moving ahead with a default/blank. If the person is present, then they can rejoin, and if not, then "defaults" will have to be selected each round and ruin a bunch of stacks
• Removing a player may be more complexity than it's worth. It's very unlikely that a player will need to be completely cut, and if they do, they can be substituted (someone can use a different browser/device with their username/gameid. Remember, same browser means localstorage conflicts). I can see this being a want though, and it might not be as hard as I think. If we don't do this though, we should at least put in the help docs that substitution is possible
• Being able to add more time is an absolute win, and probably not that hard

I'll only change the checkboxes on the original post for posterity, and put my new expectations for the remaining tasks afterwards

[Jacob-Griffin]

New "host options" for if a game is stuck

These should appear for the host if the time goes over by several seconds without the round moving on

• [x] Add time
• [x] Link to help wiki
• (optional/hook) Remove the missing player(s). If this ends up being necessary/wanted, there should be a separate issue to capture that work.

[Jacob-Griffin]

Short of a player that:

• Disconnects,
• Can't come back for one reason or another on their own circumstances, and
• Has nobody willing to sub in,

round safety options should be pretty robust. Most disconnects will be for players that'll be right back in, and between adding time and rejoin game options, there should be no problem accommodating a rejoining player. With this process being noted in the "Knowlege Base", and said kb being linked to when the round is "stuck", the core of the issue is pretty much gone.

With the edge case above, it may be worth adding "Remove missing players" as a very low priority option for the future, in its own issue, but seems like mostly reasonable workarounds for now.

That being said, moving that out into its own issue (#26), the rest of this is complete. Closing