search

JacobDomagala / StaticAnalysis

GitHub action performs static analysis on C++/Python code, flags issues, and posts comments directly on PRs.
MIT License
31 stars 10 forks source link

Only works with pull requests #25

Closed skrobinson closed 2 years ago

skrobinson commented 3 years ago

It would be nice if StaticAnalysis would work with other actions as well as PR. I'm trying out SA and want to repeatedly trigger it while I make changes to the configuraton. Either push or manual triggers would help during setup.

devinsodhi commented 3 years ago

I second this. For some reason, trying to run on push simply fails on the python script. It would be nice to associate a badge with a successful merge/push that shows a pass condition.

JacobDomagala commented 3 years ago

Yes, currently it only works on PR and this is intended. I suppose this action could be modified to also run on push (with the addition of input variable, or perhaps it could be detected on runtime, using GitHub's environment variables), and then it would just output the result to console/stdout.

If I find some time in near future, I will try to implement that.

JacobDomagala commented 2 years ago

I've pushed the changes to master branch, this Action should now work with "on-push" scenario.

Let me know if there're any issues. I'm closing the issue for now.