search

JacobDomagala / StaticAnalysis

GitHub action performs static analysis on C++/Python code, flags issues, and posts comments directly on PRs.
MIT License
31 stars 10 forks source link

custom build directory #91

Closed jbbjarnason closed 1 year ago

jbbjarnason commented 1 year ago

Is it possible to specify custom build directory?

This would be super useful when binaryDir tag is set in CMakePresets (https://cmake.org/cmake/help/latest/manual/cmake-presets.7.html)

JacobDomagala commented 1 year ago

Currently it's not possible (SA will create 'build' directory "$GITHUB_WORKSPACE/build"). I agree that it could be useful, I will try to add it soon. Thanks!

JacobDomagala commented 1 year ago

After reading a bit about the presets, wouldn't setting the cmake_args action input with --preset xxx or -b xxx as another way of specifying output dir be sufficent?

Is that something that you had in mind?

jbbjarnason commented 1 year ago

It did not work to pass -B build --preset <preset_name> I got weird errors so I made a new preset with build as build directory which works fine

JacobDomagala commented 1 year ago

Closing the issue then