Allow MCMCChains v4.0.

[hellemo]

It appears the new version of MCMCChains doesn't break anything, so would be nice to allow it.

[hellemo]

It turns out some results processing breaks from changes in MCMCChains, what would be the best approach here, a new breaking release of Jags.jl as well?

[goedman]

Hi Lars,

You mean functions part of Jags.jl? Do you have an example?

Rob

[hellemo]

It seems to me like it doesn't break Jags.jl itself, but the code using Jags.jl might break (and mine did) due to differences in the structure of the chains. Two issues I experienced were:

• chain.name_map[:parameters] now returns a Array{Symbol,1}, and that used to be Array{String,1}

• the dimensions were different when reading the values for a parameter from a chain, which broke our code to calculate e.g. percentiles

So while you might argue that it doesn't break Jags.jl, it could break user code, and perhaps better to avoid that by incrementing the major version.

[goedman]

Or should we suggest in those cases to add the latest version of MCMCChains@3?

[hellemo]

It should be easy to fix by adding compat bounds or by pinning MCMCChains to v3, but still annoying if a simple update breaks your code and you have to fix something. If you don't want to increment the major version, adding that suggestion to the release notes would be a good idea.

[goedman]

Oops, I jumped too soon on this one, shouldn't have merged. I'll add a note to the README!

[hellemo]

Great!