search

JahwnMallard / Lab2-Pong

USAF Academy ECE383 Lab 2 - Pong via vga controller
0 stars 0 forks source link

Grades #1

Open JahwnMallard opened 10 years ago

JahwnMallard commented 10 years ago

Prelab - Check + A functionality

toddbranch commented 10 years ago

Prelab - 10

Required - 40 B - 10 A - 10

Use of Git - Check Plus - 5 - Excellent - detailed and frequent. Keep doing what you're doing. Code Style - Check - 4 - If you're not going to use all the fields in the header, just eliminate them altogether. Be consistent in your indentation - all your processes should be indented in the pong_control module! Replace magic numbers with constants - a lot of them in pixel_gen! Nice work adding a package - but remove all the commented code that you're not using! README - Check - 17 - I like the addition of the Versions section - first time I've seen that! Introduce the functionality of the game first, then your state machine diagram to create the functionality, then code to realize it, then top-level. You jump right into code and FSM implementation without addressing the problem and showing your solution. I like the Troubleshooting section - but, particularly in your pong_control issues, give me concrete code causes and code solutions. Code examples would work great there. I like the Confirming Functionality and Lessons Learned - not sure if you're just humoring me, but you have some solid takeaways here.. You're close to a Check Plus - just follow my comments for the next one.

Total - 96