search

JaimstheName / homework_landing_page

0 stars 0 forks source link

Feedback on assignment 2 #1

Open barryross opened 7 years ago

barryross commented 7 years ago

FEWD Week #2 Project: Styling with CSS

Description

A hot, new NY Tech Startup, Relaxr, has approached you to help them develop a new landing page for their company. They've handed you the design file for the site, along with the copy and assets. You need to take these files and turn it into a landing page.

Student: Jaimie Stevens

Project URL: https://github.com/JaimstheName/homework_landing_page
Technical Requirements Does Not Meet Expectations (0) Meets Expectations (1) Exceeds Expectations (2)
Use HTML5 structural elements (nav, header, footer) x
Use a reset.css or normalize.css file in addition to your style.css file to style the page x
Use IDs and Classes to to select and style elements on the page x
Use at least two flex containers, each with at least two flex items x
Style your text with the Google Fonts provided by your style guide n/a
Follow naming conventions, maintain consistency across .html and .css files and use best practices for naming IDs and Classes x
Indent nested elements to increase your code's readability x
TOTAL: 10/12
barryross commented 7 years ago

Jaimie,

Nice work on this assignment! You are doing some great things here! Nice work using flex for the section and hitting many of the other technical requirements.

There are some places where I think elements could be nested inside of each other, and I was hoping to see another flex container, per the requirements. . Please see inline comments for more information, and let me know if you have any additional questions!

Keep up the great work!