JaimstheName / homework_landing_page

0 stars 0 forks source link

Feedback on assignment 3 #2

Open barryross opened 7 years ago

barryross commented 7 years ago

FEWD Week #3 Project: Multi-Column layout


Description

Student: Jaimie Stevens

Project URL: https://github.com/JaimstheName/homework_landing_page

Technical Requirements Does Not Meet Expectations (0) Meets Expectations (1) Exceeds Expectations (2)
Use either a normalize.css or reset.css (see links in class resources from Unit 3) x
Use CSS grid to achieve a 3-column layout x
Use proper filename conventions (lowercase, .html) x
Use a single external CSS stylesheet to style all pages (add onto the one you used for the landing page) x
Use at least 4 relevant semantic HTML5 elements (nav,header, article,footer etc.) x
Use CSS Flexbox to layout the contents of at least one structural component (e.g. logo and navbar within <header>) x
Add a hover effect to the navigation links in the sidebar using pseudo-classes x
TOTAL: 7/14
barryross commented 7 years ago

Hey Jaimie,

Nice work linking both pages to the same stylesheet, and making some great choices in terms of element selection.

I can see that you are wrestling with the layout (grid and flex). I strongly encourage you to go back and review the layout challenge example solutions to help strengthen your grasp of the multi-column layouts and flex layout. I think you will find it helpful! Please feel free to reach out with additional questions and remember to acknowledge the progress you are making along the way! This can be difficult stuff to learn!

Please see inline comments for additional feedback! BTW...you are always welcome to make adjustments and re-submit if you would like me to re-review/grade.

barryross commented 7 years ago

Also...bonus point for linking to the Google Fonts and hitting some of the font-style requirements in the design spec in assignment 2!