Jaliborc / Bagnon

Single window displays for you items
200 stars 112 forks source link

wotlk classic search with cached bank open causes error #1597

Open ssateneth opened 1 year ago

ssateneth commented 1 year ago

Running Software (issues missing this information will be deleted):

Describe the bug lua error when I type in a search with my bank open without being at the bank (cached bank)

To Reproduce Steps to reproduce the behaviour:

  1. be away from your bank
  2. open your cached bank by right clicking the small bag icon in top left of your bags, left click "bank" so bank opens up
  3. double left click the "'s Bank to enable search by typing
  4. type stuff in (like the letter a)
  5. get error, and things that should fade out because of not matching search don't fade out

Expected behaviour search is supposed to work and not give lua error and fade things out if they don't match search with cached bank open

Screenshots screenshot image image

Error Logs `ID:1 1/2 Message: bad argument #1 to '?' (Usage: local itemLink = C_Item.GetItemLink(itemLocation)) Time: Tue Dec 20 15:24:07 2022 Count: 522 Stack: bad argument #1 to '?' (Usage: local itemLink = C_Item.GetItemLink(itemLocation)) [string "=[tsm error check]"]:1: in main chunk

string "=[C]": in function GetItemLink' [string "@Interface\AddOns\BagBrother\libs\ItemSearch-1.3\API.lua"]:40: in functionMatches' [string "@Interface\AddOns\BagBrother\addons\core\classes\item.lua"]:296: in function `?' [string "@Interface\AddOns\AtlasLootClassic\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua"]:119: in function <...sic\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:119>

[string "@Interface\AddOns\AtlasLootClassic\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua"]:29: in function <...sic\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:25> [string "@Interface\AddOns\AtlasLootClassic\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua"]:64: in function SendMessage' [string "@Interface\AddOns\BagBrother\libs\WildAddon-1.0\WildAddon-1.0.lua"]:83: in functionSendSignal' [string "@Interface\AddOns\Bagnon\src\searchFrame.lua"]:78: in function <Interface\AddOns\Bagnon\src\searchFrame.lua:74>

Locals:

`ID:2 2/2 Message: bad argument #1 to '?' (Usage: local itemLink = C_Item.GetItemLink(itemLocation)) Time: Tue Dec 20 15:23:57 2022 Count: 29 Stack: bad argument #1 to '?' (Usage: local itemLink = C_Item.GetItemLink(itemLocation)) [string "=[tsm error check]"]:1: in main chunk

string "=[C]": in function GetItemLink' [string "@Interface\AddOns\BagBrother\libs\ItemSearch-1.3\API.lua"]:40: in functionMatches' [string "@Interface\AddOns\BagBrother\addons\core\classes\item.lua"]:296: in function `?' [string "@Interface\AddOns\AtlasLootClassic\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua"]:119: in function <...sic\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:119>

[string "@Interface\AddOns\AtlasLootClassic\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua"]:29: in function <...sic\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:25> [string "@Interface\AddOns\AtlasLootClassic\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua"]:64: in function SendMessage' [string "@Interface\AddOns\BagBrother\libs\WildAddon-1.0\WildAddon-1.0.lua"]:83: in functionSendSignal' [string "@Interface\AddOns\Bagnon\src\title.lua"]:56: in function <Interface\AddOns\Bagnon\src\title.lua:54>

Locals:

Additional context i dont know, i jsut get an error and the addon doesnt work

alexnaumovich commented 1 year ago

Looks similar to https://github.com/Jaliborc/Bagnon/issues/1590.