Jaliborc / Bagnon

Single window displays for you items
200 stars 112 forks source link

new bug todays release #1957

Open 1Holy-Z opened 2 months ago

1Holy-Z commented 2 months ago

with todays new update I open my bag and then mailbox and all the bag slots disappear and just shows a blank frame

9x bad argument #1 to '?' (Usage: local data = C_TooltipInfo.GetHyperlink(hyperlink [, optionalArg1, optionalArg2, hideVendorPrice])) string "=[C]": in function GetHyperlink' [string "@BagBrother/libs/ItemSearch-1.3-9/API.lua"]:90: in functionIsUncollected' [string "@Scrap/addons/main/main.lua"]:155: in function IsFiltered' [string "@Scrap/addons/main/main.lua"]:72: in functionIsJunk' [string "@Bagnon_Scrap/Bagnon_Scrap.lua"]:43: in function `UpdateBorder' [string "@BagBrother/core/classes/item.lua"]:127: in function <BagBrother/core/classes/item.lua:122>

[string "@PetTracker/libs/Poncho-2.0-4/Poncho-2.0.lua"]:40: in function Update' [string "@BagBrother/frames/inventory/item.lua"]:90: in function <BagBrother/frames/inventory/item.lua:89> [string "=[C]"]: in functionShow' [string "@BagBrother/core/api/frames.lua"]:32: in function Show' [string "@BagBrother/core/api/frames.lua"]:24: in function <BagBrother/core/api/frames.lua:23> [string "=[C]"]: in function?' [string "@BagBrother/core/features/autoDisplay.lua"]:18: in function <...faceBagBrother/core/features/autoDisplay.lua:18> [string "@BagBrother/core/features/autoDisplay.lua"]:83: in function `ToggleAllBags'

Locals: (*temporary) = "bad argument #1 to '?' (Usage: local data = C_TooltipInfo.GetHyperlink(hyperlink [, optionalArg1, optionalArg2, hideVendorPrice]))"

mixMugz commented 2 months ago

Same here

shazzmuzik commented 2 months ago

Yep same issue here too

Licen-it commented 2 months ago

It seems this bug is preventing me to use scrap selling junk items as well as on second opening of the bags...part of my bags disappear

Licen-it commented 2 months ago

FYI i just reverted to version 11.0.17 and it's working good

GilezDavidson commented 2 months ago

Same issue, but as with Licen-it reverting back seems to work fine.

hshh commented 2 months ago

Fix for Scrap not update yet

--- a/Interface/AddOns/Scrap/addons/main/main.lua
+++ b/Interface/AddOns/Scrap/addons/main/main.lua
@@ -152,7 +152,7 @@ function Scrap:IsFiltered(id, ...)

        elseif class == ARMOR or class == WEAPON then
                if value and slot ~= 'INVTYPE_TABARD' and slot ~= 'INVTYPE_BODY' and subclass ~= FISHING_POLE then
-                       if self.charsets.uncollected or not Search:IsUncollected(id) then
+                       if self.charsets.uncollected or not Search:IsUncollected(id, link) then
                                if quality == POOR then
                                        return bound ~= LE_ITEM_BIND_ON_EQUIP and ((slot ~= 'INVTYPE_SHOULDER' and level > INTRO_BREAKPOINT) or level > SHOULDER_BREAKPOINT)
                                elseif quality >= UNCOMMON and quality <= EPIC and location and C.Item.IsBound(location) then