Jaliborc / PetTracker

Tracks pets, alerts for upgrades and helps you in pet battles.
49 stars 26 forks source link

error on load in (swatter output included)(triggered pr 389) #388

Closed JPEscher closed 2 months ago

JPEscher commented 3 months ago

Which software were you running?

Have you read the changelog? Mark if read. Yes

Please describe the bug. error pops up on login

Please describe how to reproduce it. Login

Any Screenshots? not applicable

Error Logs are Important! Date: 2024-07-31 13:54:27 ID: 48 Error occured in: Global Count: 1 Message: ...AddOns/PetTracker/addons/main/features/mapSearch.lua line 14: attempt to call field 'Dropdown' (a nil value) Debug: [string "@Interface/AddOns/PetTracker/addons/main/features/mapSearch.lua"]:14: ?()

  ...dOns/PetTracker/libs/WildAddon-1.0/WildAddon-1.0.lua:18
  ...dOns/PetTracker/libs/WildAddon-1.0/WildAddon-1.0.lua:53
  ...lic/Libs/CallbackHandler-1.0/CallbackHandler-1.0.lua:15

string "@Interface/AddOns/Altoholic/Libs/CallbackHandler-1.0/CallbackHandler-1.0.lua":54: Fire()

  ...ace/AddOns/TomTom/libs/AceEvent-3.0/AceEvent-3.0.lua:119

string "@Interface/AddOns/Blizzard_UIParent/Mainline/UIParent.lua":422: UIParentLoadAddOn() string "@Interface/AddOns/Blizzard_UIParent/Mainline/UIParent.lua":477: CombatLog_LoadUI()

  ...rface/AddOns/Blizzard_UIParent/Mainline/UIParent.lua:1289

Locals: self =

{ Tag = "PETTRACKER_" } (temporary) = nil (temporary) = UIParent { variablesLoaded = true firstTimeLoaded = 1 Tabs =
{ } } (*temporary) = "attempt to call field 'Dropdown' (a nil value)" ADDON = "PetTracker" L =
{ Switcher = "Switcher" Tutorial =
{ } TellMore = "Tell me more about yourself." RivalPortraits = "Rival Portraits" MissingRares = "Missing Rares" DisplayCondition = "Display Condition" FilterSpecies = "Filter Species" Species = "Species" OptionsDescription = "These options allow you to toggle PetTracker general features on and off. Gotta catch them all!" Source6 = "Achievement" Maximized = "Maximized" HelpDescription = "Here we provide answers to the most frequently asked questions. We also recommend following the ingame tutorial. If neither solve your problem, you might consider asking for help on the PetTracker user community on discord." SpecieIconsTip = "If enabled, pets will be marked by their species icon instead of type when shown in the world and battle map." TotalRivals = "Total Rivals" Ninja = "Ninja" Source9 = "Trading Card Game" AddWaypoint = "Add Waypoint" AvailableBreeds = "Available Breeds" ZoneTrackerTip = "If enabled, a list of pet capture progress in the current zone will be displayed next to the quest objectives.|n|n|cff20ff20You can also toggle this option from the Pet Journal.|r" ShowStables = "Show Stables" Breed = "Breed" ZoneTracker = "Zone Tracker" SpecieIcons = "Specie Icons" AlertUpgrades = "Alert for Upgrades" UpgradeAlert = "Wild upgrades have appeared!" EnemyTeam = "Enemy Team" Source1 = "Drop" Defeat = "Defeat" Source4 = "Profession" Source8 = "Promotion" Source10 = "In-Game Shop" ShowJournal = "Show in Journal" Victory = "Victory" Source11 = "Discovery" Source12 = "Trading Post" PatronsDescription = "PetTracker is distributed for free and supported trough donations. A massive thank you to all the supporters on Patreon and Paypal who keep development alive. You can become a patron too at |cFFF96854patreon.com/jaliborc|r." StableTip = "|cffffd200Come here to heal your|npets for a small fee.|r" Source2 = "Quest" CapturedPets = "Show Captured" Rivals = "Rivals" NoHistory = "PetTracker has never seen you fight this adversary" AlertUpgradesTip = "If disabled, an upgrades alert box will not be shown in combat, but upgrades will still be marked with a symbol (|TInterface/GossipFrame/AvailableQuestIcon:0:0:-1:-2|t)." ShowPets = "Show Battle Pets" Source7 = "World Event" FAQ =
{ } ForfeitTip = "If enabled, will ask whether to forfeit a wild battle when no upgrades are available." RivalPortraitsTip = "If enabled, rivals will be marked by their portraits when shown in the world and battle map." Source5 = "Pet Battle" NoneCollected = "None Collected" LoadTeam = "Load Team" AskForfeit = "No upgrades are available. Quit battle?" BreedExplanation = "Determines how stats gained at each level are distributed." Source3 = "Vendor" TrackPets = "Track Pets" Forfeit = "Prompt for Forfeit" MissingPets = "Missing Pets" CommonSearches = "Common Searches" SwitcherTip = "If enabled, the default UI for switching pets in combat will be replaced by an improved one." }

AddOns: Swatter, v<%version%> (<%codename%>) AddonFactory, v11.0.001 Altoholic, v11.0.001 AstralKeys, v4.10 Auctioneer, v9.1.BETA.5.17 (OneMawTime) AuctioneerStatsOverTime, v9.1.BETA.5.17 (OneMawTime) AuctioneerUtilDealFinder, v9.1.BETA.5.17 (OneMawTime) AuctioneerUtilValuer, v9.1.BETA.5.17 (OneMawTime) BattlePetBreedID, vv1.29.0 Clique, vv4.0.20-release CursorTrail, v11.0.0.1 DataStore, v2024.07.28 DataStoreAchievements, v2024.07.28 DataStoreAgenda, v2024.07.28 DataStoreAuctions, v2024.07.28 DataStoreCharacters, v2024.07.28 DataStoreContainers, v2024.07.28 DataStoreCrafts, v2024.07.28 DataStoreCurrencies, v2024.07.28 DataStoreGarrisons, v2024.07.28 DataStoreInventory, v2024.07.28 DataStoreMails, v2024.07.28 DataStorePets, v2024.07.28 DataStoreQuests, v2024.07.28 DataStoreReputations, v2024.07.28 DataStoreSpells, v2024.07.28 DataStoreStats, v2024.07.28 DataStoreTalents, v2024.07.28 DBMCore, v11.0.2 DBMSpellTimers, vr157 DBMStatusBarTimers, v11.0.2 DBMVPVEM, veeae112 Details, v#Details.12822.159 DetailsCompare2, v DetailsEncounterDetails, v DetailsRaidCheck, v DetailsStreamer, v DetailsTinyThreat, v DetailsVanguard, v GlobalIgnoreList, v10.2.6 GTFO, v5.10 HandyNotes, vv1.6.20.3 InstanceAchievementTracker, v5.2.0 Mapster, v1.12.0 MRT, v4880 MythicDungeonTools, v5.0.1 OmniCD, v10.2.7.2802 Pawn, v2.9.14 PetTracker, v10.2.7 Prat30, v3.9.55 RaiderIO, v10.2.7 (v202407310600) RaiderIODBUSM, v10.2.7 (v202407310600) RaiderIODBUSR, v10.2.7 (v202407310600) Rematch, v5.2.2 SlideBar, v<%version%> (<%codename%>) Stubby, v9.1.BETA.5.17 (OneMawTime) TomTom, vv4.0.1-release VuhDo, v3.171 VuhDoOptions, v3.171 WeakAuras, v5.15.4 WeakAurasArchive, v5.15.4 BlizRuntimeLib v11.0.0.55933(US) (ck=71b)

JPEscher commented 3 months ago

i logged into chamber of the guardian - portal room

JPEscher commented 2 months ago

similar login issue in valdrakken

Date: 2024-08-10 12:02:05
ID: 1
Error occured in: Global
Count: 1
Message: ...ace/AddOns/PetTracker/libs/Poncho-2.0/Poncho-2.0.lua line 183:
   attempt to index a nil value
Debug:
   [string "@Interface/AddOns/PetTracker/libs/Poncho-2.0/Poncho-2.0.lua"]:183: in main chunk
Locals:
Lib = <table> {
 SuperCall = <table> {
 }
 ClassMeta = <table> {
 }
 Base = <table> {
 }
}
Base = <table> {
 __type = "Abstract"
}
ClassMeta = <table> {
}
SuperCall = <table> {
}
(*temporary) = <table> {
 Abstract = <table> {
 }
 Frame = <table> {
 }
}
(*temporary) = nil
(*temporary) = nil
(*temporary) = "attempt to index a nil value"

AddOns:
  Swatter, v<%version%> (<%codename%>)
  AddonFactory, v11.0.001
  Altoholic, v11.0.001
  AstralKeys, v4.10
  Auctioneer, v9.1.BETA.5.17 (OneMawTime)
  AuctioneerStatsOverTime, v9.1.BETA.5.17 (OneMawTime)
  AuctioneerUtilDealFinder, v9.1.BETA.5.17 (OneMawTime)
  AuctioneerUtilValuer, v9.1.BETA.5.17 (OneMawTime)
  BattlePetBreedID, vv1.29.0
  Clique, vv4.0.20-release
  CursorTrail, v11.0.0.1
  DataStore, v2024.07.28
  DataStoreAchievements, v2024.07.28
  DataStoreAgenda, v2024.07.28
  DataStoreAuctions, v2024.07.28
  DataStoreCharacters, v2024.07.28
  DataStoreContainers, v2024.07.28
  DataStoreCrafts, v2024.07.28
  DataStoreCurrencies, v2024.07.28
  DataStoreGarrisons, v2024.07.28
  DataStoreInventory, v2024.07.28
  DataStoreMails, v2024.07.28
  DataStorePets, v2024.07.28
  DataStoreQuests, v2024.07.28
  DataStoreReputations, v2024.07.28
  DataStoreSpells, v2024.07.28
  DataStoreStats, v2024.07.28
  DataStoreTalents, v2024.07.28
  DBMCore, v11.0.2
  DBMSpellTimers, vr157
  DBMStatusBarTimers, v11.0.2
  DBMVPVEM, veeae112
  Details, v#Details.12829.159
  DetailsCompare2, v
  DetailsEncounterDetails, v
  DetailsRaidCheck, v
  DetailsStreamer, v
  DetailsTinyThreat, v
  DetailsVanguard, v
  GlobalIgnoreList, v11.0.0
  GTFO, v5.10
  HandyNotes, vv1.6.20.3
  InstanceAchievementTracker, v5.3.0
  Mapster, v1.12.0
  MRT, v4890
  MythicDungeonTools, v5.0.2
  OmniCD, v10.2.7.2802
  Pawn, v2.9.14
  PetTracker, v10.2.7
  SlideBar, v<%version%> (<%codename%>)
  Stubby, v9.1.BETA.5.17 (OneMawTime)
  TomTom, vv4.0.1-release
  BlizRuntimeLib v11.0.0.56008(US) <enUS>
  (ck=629)
JPEscher commented 2 months ago

just noticed today it's id 1 through 48 for pettracker

would you like all 48 posted?

JPEscher commented 2 months ago

it's dead jim.

today's patch upped the number of errors. it's like half the code points to nil values and a barrage of errors 😢 😭

JPEscher commented 2 months ago

tried to fork to fix, i seem to be missing a LOT.... however i did note that i can fix one by opening "C:\Program Files (x86)\World of Warcraft_retail_\Interface\AddOns\PetTracker\libs\TaintLess\TaintLess.xml" and adding

local GetAddOnMetadata = GetAddOnMetadata or C_AddOns.GetAddOnMetadata

sometime before

local patch do
    local q, skips = {}, securecall(function()
        local cb, r, _, an = select(4,GetBuildInfo()), {moon="haunted"}
        r.moon, _, an = nil, issecurevariable(r, "moon")
        for m, v, clo, chi in (GetAddOnMetadata(an, "X-TaintLess-DisableMitigations") or ""):gmatch("([%a_]+)=(%d+):?(%d*):?(%d*)") do
            if (clo == "" or cb >= clo+0) and (chi == "" or chi+0 >= cb) then
                r[m] = v + 0
            end
        end
        return r
    end)
    function patch(name, version, impl)
        if name == nil then
            for qf, v in pairs(q) do
                securecall(qf, v)
            end
        elseif not ((tonumber(_G[name]) or 0) >= version or skips and skips[name] == version) then
            _G[name], q[impl] = version, version
        end
    end
end
Amalia-Fleur commented 2 months ago

i think you better start with the updated lib (or take and compare the lib from his/her other projects) before modifiying the old one. https://www.townlong-yak.com/addons/taintless or for example from bagnon i can see that your mentioned fix is already implemented -> changed into C_AddOns.GetAddOnMetadata

maybe updating all used libs will already eliminate some errors...

good luck :)

JPEscher commented 2 months ago

i think you better start with the updated lib (or take and compare the lib from his/her other projects) before modifiying the old one. https://www.townlong-yak.com/addons/taintless or for example from bagnon i can see that your mentioned fix is already implemented -> changed into C_AddOns.GetAddOnMetadata

maybe updating all used libs will already eliminate some errors...

good luck :)

ty. i didnt realize that was a reference to another place. i stopped when i realized poncho and a few others were but did not have a chance to look for any yet.

i'll wait for the author, who i would expect knows where all the plugins are, to look for updates then

Amalia-Fleur commented 2 months ago

many libs need to be changed, and i think the addon itselfes need to be updated to reflect the changes in the libs

the author is active, maybe just too many things to fix atm...

JPEscher commented 2 months ago

a friend just linked me a discord. from there. image i think this shows we should wait because he's got business trips. being a patient fan can pay off.

JPEscher commented 2 months ago

Notes on some actions that helped.... (note, i ignored the .github folder in the zips)

adjustments to Interface\AddOns\PetTracker\addons\main\features\objectives.lua

  • update line 6 to: if LibStub('C_Everywhere').Addons.C_AddOns.IsAddOnLoaded('Carbonite.Quests') then

adjustments to Interface\AddOns\PetTracker\localization\en.lua

  • update line 40 to: L.TrackPets = C_Spell.GetSpellInfo(122026)

now down to one error

Date: 2024-08-16 23:17:46
ID: 1
Error occured in: Global
Count: 1
Message: ...ddOns/PetTracker/addons/main/features/objectives.lua line 24:
   CreateFrame(): Couldn't find inherited node "ObjectiveTrackerHeaderTemplate"
Debug:
   [string "=[C]"]: CreateFrame()
   [string "@Interface/AddOns/PetTracker/addons/main/features/objectives.lua"]:24: ?()
   [string "@Interface/AddOns/PetTracker/libs/WildAddon-1.0/WildAddon-1.0.lua"]:20:
      ...dOns/PetTracker/libs/WildAddon-1.0/WildAddon-1.0.lua:18
   [string "@Interface/AddOns/PetTracker/libs/WildAddon-1.0/WildAddon-1.0.lua"]:56:
      ...dOns/PetTracker/libs/WildAddon-1.0/WildAddon-1.0.lua:53
   [string "=[C]"]: ?
   [string "@Interface/AddOns/Altoholic/Libs/CallbackHandler-1.0/CallbackHandler-1.0.lua"]:19:
      ...lic/Libs/CallbackHandler-1.0/CallbackHandler-1.0.lua:15
   [string "@Interface/AddOns/Altoholic/Libs/CallbackHandler-1.0/CallbackHandler-1.0.lua"]:54: Fire()
   [string "@Interface/AddOns/TomTom/libs/AceEvent-3.0/AceEvent-3.0.lua"]:120:
      ...ace/AddOns/TomTom/libs/AceEvent-3.0/AceEvent-3.0.lua:119
   [string "=[C]"]: ?
   [string "=[C]"]: LoadAddOn()
   [string "@Interface/AddOns/Blizzard_UIParent/Mainline/UIParent.lua"]:422: UIParentLoadAddOn()
   [string "@Interface/AddOns/Blizzard_UIParent/Mainline/UIParent.lua"]:565: TimeManager_LoadUI()
   [string "@Interface/AddOns/Blizzard_UIParent/Mainline/UIParent.lua"]:1410:
      ...rface/AddOns/Blizzard_UIParent/Mainline/UIParent.lua:1290
Locals:
(*temporary) = "Button"
(*temporary) = "PetTrackerObjectiveTrackerHeader"
(*temporary) = Frame {
 Lines = <table> {
 }
 Index = 1
 Anchor = Frame {
 }
 MaxEntries = 0
 Tag = "PETTRACKER_"
 Bar = Frame {
 }
}
(*temporary) = "ObjectiveTrackerHeaderTemplate"

AddOns:
  Swatter, v<%version%> (<%codename%>)
  AddonFactory, v11.0.002
  Altoholic, v11.0.002
  AstralKeys, v4.11
  Auctioneer, v11.x.BETA.3 (TheWarWithBlizzardAPIs)
  AuctioneerStatsOverTime, v11.x.BETA.3 (TheWarWithBlizzardAPIs)
  AuctioneerUtilDealFinder, v11.x.BETA.3 (TheWarWithBlizzardAPIs)
  AuctioneerUtilValuer, v11.x.BETA.3 (TheWarWithBlizzardAPIs)
  BattlePetBreedID, vv1.30.2
  Clique, vv4.0.22-release
  CursorTrail, v11.0.2.1
  DataStore, v2024.08.14
  DataStoreAchievements, v2024.08.14
  DataStoreAgenda, v2024.08.14
  DataStoreAuctions, v2024.08.14
  DataStoreCharacters, v2024.08.14
  DataStoreContainers, v2024.08.14
  DataStoreCrafts, v2024.08.14
  DataStoreCurrencies, v2024.08.14
  DataStoreGarrisons, v2024.08.14
  DataStoreInventory, v2024.08.14
  DataStoreMails, v2024.08.14
  DataStorePets, v2024.08.14
  DataStoreQuests, v2024.08.14
  DataStoreReputations, v2024.08.14
  DataStoreSpells, v2024.08.14
  DataStoreStats, v2024.08.14
  DataStoreTalents, v2024.08.14
  DBMCore, v11.0.2
  DBMSpellTimers, vr157
  DBMStatusBarTimers, v11.0.2
  DBMVPVEM, veeae112
  Details, v#Details.12829.159
  DetailsCompare2, v
  DetailsEncounterDetails, v
  DetailsRaidCheck, v
  DetailsStreamer, v
  DetailsTinyThreat, v
  DetailsVanguard, v
  GlobalIgnoreList, v11.0.0
  GTFO, v5.11.2
  HandyNotes, vv1.6.20.3
  InstanceAchievementTracker, v5.3.0
  Mapster, v1.12.0
  MRT, v4900
  MythicDungeonTools, v5.0.4
  OmniCD, v10.2.7.2802
  Pawn, v2.10.0
  PetTracker, v10.2.7
  Prat30, v3.9.58
  RaiderIO, v10.2.7 (v202408160600)
  RaiderIODBUSM, v10.2.7 (v202408160600)
  RaiderIODBUSR, v10.2.7 (v202408160600)
  Rematch, v5.2.4
  SlideBar, v11.x.BETA.3 (TheWarWithBlizzardAPIs)
  Stubby, v11.x.BETA.3 (TheWarWithBlizzardAPIs)
  TomTom, vv4.0.1-release
  VuhDo, v3.172
  VuhDoOptions, v3.172
  WeakAuras, v5.16.1
  WeakAurasArchive, v5.16.1
  BlizRuntimeLib v11.0.2.56162(US) <enUS>
  (ck=759)
JPEscher commented 2 months ago

the wildaddon issue seems to be IsLoggedIn but im not certain.

JPEscher commented 2 months ago

added a pr to help bring attention. best i can do at the moment

Amalia-Fleur commented 2 months ago

good work :) just in case, maybe it helps you, errors with only pettracker loaded... (i did delete bugsackr related errors) it seems you have an addon loaded which already fixed aceevent and this is loaded instead of the one packed with this addon

1x ...ddOns/PetTracker/addons/main/features/objectives.lua:24: CreateFrame(): Couldn't find inherited node "ObjectiveTrackerHeaderTemplate" string "=[C]": in function CreateFrame' [string "@PetTracker/addons/main/features/objectives.lua"]:24: in function?' [string "@PetTracker/libs/WildAddon-1.0-2/WildAddon-1.0.lua"]:20: in function <...dOns/PetTracker/libs/WildAddon-1.0/WildAddon-1.0.lua:18> [string "@PetTracker/libs/WildAddon-1.0-2/WildAddon-1.0.lua"]:56: in function <...dOns/PetTracker/libs/WildAddon-1.0/WildAddon-1.0.lua:53>

[string "@PetTracker/libs/AceEvent-3.0-4/AceEvent-3.0.lua"]:120: in function <PetTracker/libs/AceEvent-3.0/AceEvent-3.0.lua:119>

string "=[C]": in function LoadAddOn' [string "@Blizzard_UIParent/Mainline/UIParent.lua"]:422: in functionUIParentLoadAddOn' [string "@Blizzard_UIParent/Mainline/UIParent.lua"]:565: in function `TimeManager_LoadUI' [string "@Blizzard_UIParent/Mainline/UIParent.lua"]:1410: in function <...rfaceBlizzard_UIParent/Mainline/UIParent.lua:1290>

Locals: (temporary) = "Button" (temporary) = "PetTrackerObjectiveTrackerHeader" (temporary) = Frame { Lines =

{ } Index = 1 Anchor = Frame { } MaxEntries = 0 Tag = "PETTRACKER_" Bar = Frame { } } (temporary) = "ObjectiveTrackerHeaderTemplate"

and:

1x ...ddOns/PetTracker/addons/main/features/objectives.lua:64: attempt to index upvalue 'Minimize' (a nil value) [string "@PetTracker/addons/main/features/objectives.lua"]:64: in function UpdateMinimize' [string "@PetTracker/addons/main/features/objectives.lua"]:58: in function?' [string "@PetTracker/libs/WildAddon-1.0-2/WildAddon-1.0.lua"]:100: in function `func' [string "@PetTracker/libs/MutexDelay-1.0-2/MutexDelay-1.0.lua"]:36: in function <...ns/PetTracker/libs/MutexDelay-1.0/MutexDelay-1.0.lua:30>

Locals: self = Frame { Lines =

{ } Index = 1 Anchor = Frame { } MaxEntries = 0 Tag = "PETTRACKER_" Bar = Frame { } } (temporary) = nil (temporary) = nil (temporary) = true (temporary) = nil (temporary) = nil (temporary) = nil (*temporary) = "attempt to index upvalue 'Minimize' (a nil value)" Minimize = nil

JPEscher commented 2 months ago

@Amalia-Fleur TY! i was just going back to reread and saw your post. from powershell

PS C:\Program Files (x86)\World of Warcraft\_retail_\Interface\AddOns> Get-ChildItem -Recurse -Name | Where-Object { $_.contains('AceEvent') }
HandyNotes\Libs\AceEvent-3.0
HandyNotes\Libs\AceEvent-3.0\AceEvent-3.0.lua
HandyNotes\Libs\AceEvent-3.0\AceEvent-3.0.xml
Mapster\Libs\AceEvent-3.0
Mapster\Libs\AceEvent-3.0\AceEvent-3.0.lua
Mapster\Libs\AceEvent-3.0\AceEvent-3.0.xml
PetTracker\libs\AceEvent-3.0
PetTracker\libs\AceEvent-3.0\AceEvent-3.0.lua
Prat-3.0\Libs\AceEvent-3.0
Prat-3.0\Libs\AceEvent-3.0\AceEvent-3.0.lua
Prat-3.0\Libs\AceEvent-3.0\AceEvent-3.0.xml
TomTom\libs\AceEvent-3.0
TomTom\libs\AceEvent-3.0\AceEvent-3.0.lua
TomTom\libs\AceEvent-3.0\AceEvent-3.0.xml
PS C:\Program Files (x86)\World of Warcraft\_retail_\Interface\AddOns>

as mapster is still in need of an update i can rule out that version. but know itll need an update too. (will post over there haha) https://github.com/hurricup/WoW-Ace3/tree/master is the base. their release mechanism is at https://www.wowace.com/projects/ace3/files

using their latest (as of this writing is https://www.wowace.com/projects/ace3/files/5561981 )

in that folder for this from there are AceEvent-3.0 AceLocale-3.0 CallbackHandler-1.0 LibStub

after updating those from the latest release zip... it appears there's conflicts with altaholic & tomtom still... updating tomtom & altaholic to these versions... doesnt help?

hmmm let me try resetting those two and disabling them... and i hit others that have ace... as i disable the rest with ace: handy notes, prat, auctioneer suite; and load in...mapster is a conflict? disable mapster and DBM's version is a mismatch disable dbm for testing and ... details. lol disable details for testing and ... method raid tools ... mythic dungeon tools ... omnicd ...

and we finally stay in pettracker. looks liek the function changed.

Message: ...ddOns/PetTracker/addons/main/features/objectives.lua:24: CreateFrame(): Couldn't find inherited node "ObjectiveTrackerHeaderTemplate"
Time: Sat Aug 17 08:10:20 2024
Count: 1
Stack: ...ddOns/PetTracker/addons/main/features/objectives.lua:24: CreateFrame(): Couldn't find inherited node "ObjectiveTrackerHeaderTemplate"
[string "@Interface/AddOns/PetTracker/addons/main/features/objectives.lua"]:24: in function `?'
[string "@Interface/AddOns/PetTracker/libs/WildAddon-1.0/WildAddon-1.0.lua"]:20: in function <...dOns/PetTracker/libs/WildAddon-1.0/WildAddon-1.0.lua:18>
[string "@Interface/AddOns/PetTracker/libs/WildAddon-1.0/WildAddon-1.0.lua"]:56: in function <...dOns/PetTracker/libs/WildAddon-1.0/WildAddon-1.0.lua:53>
[string "=[C]"]: ?
[string "@Interface/AddOns/PetTracker/libs/CallbackHandler-1.0/CallbackHandler-1.0.lua"]:19: in function <...ker/libs/CallbackHandler-1.0/CallbackHandler-1.0.lua:15>
[string "@Interface/AddOns/PetTracker/libs/CallbackHandler-1.0/CallbackHandler-1.0.lua"]:54: in function `Fire'
[string "@Interface/AddOns/PetTracker/libs/AceEvent-3.0/AceEvent-3.0.lua"]:120: in function <...AddOns/PetTracker/libs/AceEvent-3.0/AceEvent-3.0.lua:119>
[string "=[C]"]: ?
[string "=[C]"]: in function `LoadAddOn'
[string "@Interface/AddOns/Blizzard_UIParent/Mainline/UIParent.lua"]:422: in function `UIParentLoadAddOn'
[string "@Interface/AddOns/Blizzard_UIParent/Mainline/UIParent.lua"]:565: in function `TimeManager_LoadUI'
[string "@Interface/AddOns/Blizzard_UIParent/Mainline/UIParent.lua"]:1410: in function <...rface/AddOns/Blizzard_UIParent/Mainline/UIParent.lua:1290>

Locals: self = Frame {
 Lines = <table> {
 }
 Index = 1
 Anchor = Frame {
 }
 MaxEntries = 0
 Tag = "PETTRACKER_"
 Bar = Frame {
 }
}
Parent = nil

not quite sure but at least its not an interaction issue

JPEscher commented 2 months ago

reading and sifting, it looks like this calls a non-existent template: ObjectiveTrackerHeaderTemplate

not sure where the template SHOULD live so not sure how to find if the name was updated

JPEscher commented 2 months ago

line 24 update: local header = CreateFrame('Button', 'PetTrackerObjectiveTrackerHeader', self, 'ObjectiveTrackerContainerHeaderTemplate') -- ObjectiveTrackerHeaderTemplate -> ObjectiveTrackerContainerHeaderTemplate according to https://github.com/Tercioo/World-Quest-Tracker/blob/db15d824fa4ba80e7bcdc30d126e52b001f36dc9/WorldQuestTracker_Tracker.lua#L321 as of 2024 08 17

now i have

Date: 2024-08-17 22:35:48
ID: 1
Error occured in: Global
Count: 1
Message: ...ddOns/PetTracker/addons/main/features/objectives.lua line 36:
   hooksecurefunc(): ObjectiveTracker_Update is not a function
Debug:
   [string "=[C]"]: hooksecurefunc()
   [string "@Interface/AddOns/PetTracker/addons/main/features/objectives.lua"]:36: ?()
   [string "@Interface/AddOns/PetTracker/libs/WildAddon-1.0/WildAddon-1.0.lua"]:20:
      ...dOns/PetTracker/libs/WildAddon-1.0/WildAddon-1.0.lua:18
   [string "@Interface/AddOns/PetTracker/libs/WildAddon-1.0/WildAddon-1.0.lua"]:56:
      ...dOns/PetTracker/libs/WildAddon-1.0/WildAddon-1.0.lua:53
   [string "=[C]"]: ?
   [string "@Interface/AddOns/Altoholic/Libs/CallbackHandler-1.0/CallbackHandler-1.0.lua"]:19:
      ...lic/Libs/CallbackHandler-1.0/CallbackHandler-1.0.lua:15
   [string "@Interface/AddOns/Altoholic/Libs/CallbackHandler-1.0/CallbackHandler-1.0.lua"]:54: Fire()
   [string "@Interface/AddOns/TomTom/libs/AceEvent-3.0/AceEvent-3.0.lua"]:120:
      ...ace/AddOns/TomTom/libs/AceEvent-3.0/AceEvent-3.0.lua:119
   [string "=[C]"]: ?
   [string "=[C]"]: LoadAddOn()
   [string "@Interface/AddOns/Blizzard_UIParent/Mainline/UIParent.lua"]:422: UIParentLoadAddOn()
   [string "@Interface/AddOns/Blizzard_UIParent/Mainline/UIParent.lua"]:565: TimeManager_LoadUI()
   [string "@Interface/AddOns/Blizzard_UIParent/Mainline/UIParent.lua"]:1410:
      ...rface/AddOns/Blizzard_UIParent/Mainline/UIParent.lua:1290
Locals:

AddOns:
  Swatter, v<%version%> (<%codename%>)
  AddonFactory, v11.0.002
  Altoholic, v11.0.002
  AstralKeys, v4.11
  Auctioneer, v11.x.BETA.3 (TheWarWithBlizzardAPIs)
  AuctioneerStatsOverTime, v11.x.BETA.3 (TheWarWithBlizzardAPIs)
  AuctioneerUtilDealFinder, v11.x.BETA.3 (TheWarWithBlizzardAPIs)
  AuctioneerUtilValuer, v11.x.BETA.3 (TheWarWithBlizzardAPIs)
  BattlePetBreedID, vv1.30.2
  Clique, vv4.0.23-release
  CursorTrail, v11.0.2.1
  DataStore, v2024.08.14
  DataStoreAchievements, v2024.08.14
  DataStoreAgenda, v2024.08.14
  DataStoreAuctions, v2024.08.14
  DataStoreCharacters, v2024.08.14
  DataStoreContainers, v2024.08.14
  DataStoreCrafts, v2024.08.14
  DataStoreCurrencies, v2024.08.14
  DataStoreGarrisons, v2024.08.14
  DataStoreInventory, v2024.08.14
  DataStoreMails, v2024.08.14
  DataStorePets, v2024.08.14
  DataStoreQuests, v2024.08.14
  DataStoreReputations, v2024.08.14
  DataStoreSpells, v2024.08.14
  DataStoreStats, v2024.08.14
  DataStoreTalents, v2024.08.14
  DBMCore, v11.0.2
  DBMSpellTimers, vr157
  DBMStatusBarTimers, v11.0.2
  DBMVPVEM, veeae112
  Details, v#Details.12877.159
  DetailsCompare2, v
  DetailsEncounterDetails, v
  DetailsRaidCheck, v
  DetailsStreamer, v
  DetailsTinyThreat, v
  DetailsVanguard, v
  GlobalIgnoreList, v11.0.0
  GTFO, v5.11.2
  HandyNotes, vv1.6.20.3
  InstanceAchievementTracker, v5.3.0
  Mapster, v1.12.0
  MRT, v4900
  MythicDungeonTools, v5.0.4
  OmniCD, v10.2.7.2802
  Pawn, v2.10.0
  PetTracker, v10.2.7
  Prat30, v3.9.58
  RaiderIO, v10.2.7 (v202408170600)
  RaiderIODBUSF, v10.2.7 (v202408170600)
  RaiderIODBUSM, v10.2.7 (v202408170600)
  RaiderIODBUSR, v10.2.7 (v202408170600)
  Rematch, v5.2.4
  SlideBar, v11.x.BETA.3 (TheWarWithBlizzardAPIs)
  Stubby, v11.x.BETA.3 (TheWarWithBlizzardAPIs)
  TomTom, vv4.0.1-release
  VuhDo, v3.172
  VuhDoOptions, v3.172
  WeakAuras, v5.16.1
  WeakAurasArchive, v5.16.1
  BlizRuntimeLib v11.0.2.56162(US) <enUS>
  (ck=782)

removing others with ace and

Date: 2024-08-17 22:38:18
ID: 1
Error occured in: Global
Count: 1
Message: ...ddOns/PetTracker/addons/main/features/objectives.lua line 36:
   hooksecurefunc(): ObjectiveTracker_Update is not a function
Debug:
   [string "=[C]"]: hooksecurefunc()
   [string "@Interface/AddOns/PetTracker/addons/main/features/objectives.lua"]:36: ?()
   [string "@Interface/AddOns/PetTracker/libs/WildAddon-1.0/WildAddon-1.0.lua"]:20:
      ...dOns/PetTracker/libs/WildAddon-1.0/WildAddon-1.0.lua:18
   [string "@Interface/AddOns/PetTracker/libs/WildAddon-1.0/WildAddon-1.0.lua"]:56:
      ...dOns/PetTracker/libs/WildAddon-1.0/WildAddon-1.0.lua:53
   [string "=[C]"]: ?
   [string "@Interface/AddOns/PetTracker/libs/CallbackHandler-1.0/CallbackHandler-1.0.lua"]:19:
      ...ker/libs/CallbackHandler-1.0/CallbackHandler-1.0.lua:15
   [string "@Interface/AddOns/PetTracker/libs/CallbackHandler-1.0/CallbackHandler-1.0.lua"]:54: Fire()
   [string "@Interface/AddOns/PetTracker/libs/AceEvent-3.0/AceEvent-3.0.lua"]:120:
      ...AddOns/PetTracker/libs/AceEvent-3.0/AceEvent-3.0.lua:119
   [string "=[C]"]: ?
   [string "=[C]"]: LoadAddOn()
   [string "@Interface/AddOns/Blizzard_UIParent/Mainline/UIParent.lua"]:422: UIParentLoadAddOn()
   [string "@Interface/AddOns/Blizzard_UIParent/Mainline/UIParent.lua"]:565: TimeManager_LoadUI()
   [string "@Interface/AddOns/Blizzard_UIParent/Mainline/UIParent.lua"]:1410:
      ...rface/AddOns/Blizzard_UIParent/Mainline/UIParent.lua:1290
Locals:

AddOns:
  Swatter, v<%version%> (<%codename%>)
  PetTracker, v10.2.7
  Stubby, v11.x.BETA.3 (TheWarWithBlizzardAPIs)
  BlizRuntimeLib v11.0.2.56162(US) <enUS>
  (ck=97)
JPEscher commented 2 months ago
JPEscher commented 2 months ago

think i found the fix

PetTracker\addons\main\features\objectives.lua: update line 24 to: local header = CreateFrame('Button', 'PetTrackerObjectiveTrackerHeader', self, 'ObjectiveTrackerContainerHeaderTemplate') -- ObjectiveTrackerHeaderTemplate -> ObjectiveTrackerContainerHeaderTemplate according to https://github.com/Tercioo/World-Quest-Tracker/blob/db15d824fa4ba80e7bcdc30d126e52b001f36dc9/WorldQuestTracker_Tracker.lua#L321 as of 2024 08 17 PetTracker\addons\main\features\objectives.lua: update lines 36 & added a new line of citation: -- broken by 11.0.0: ObjectiveTracker_Update --> ObjectiveTrackerManager, "UpdateAll" as per https://github.com/Tercioo/World-Quest-Tracker/blob/db15d824fa4ba80e7bcdc30d126e52b001f36dc9/WorldQuestTracker_Tracker.lua#L1653 on 2024 08 17 hooksecurefunc(ObjectiveTrackerManager, "UpdateAll", function()

JPEscher commented 2 months ago

full summary in pr 389

Amalia-Fleur commented 2 months ago

thumbs up a pitty that you got no response from author yet, even while he is active on github the last days.... priority are the other addons, but now with your PR he does not have to look at these bugs anymore anyway still think best thing would be, that you get in contact with him. (and ashame that you are on wow us, and us and eu cannot communicate....) :) Edit: @JPEscher btw, maybe https://www.curseforge.com/wow/addons/battle-pet-completionist is something for you

JPEscher commented 2 months ago

@Amalia-Fleur just noticed on discord he's reviewing

i use https://www.warcraftpets.com/collection/Noctus/ and check the "wanted" tab to see what i need to chase :) completionist might be good though. ty!

image

dashifen commented 2 months ago

First: Thanks, @JPEscher for all your work here. Second, and only tangentially related: which Discord? Is there one for pet collectors that I'm unaware of?!

JPEscher commented 2 months ago

@dashifen @Amalia-Fleur jaliborc has his own discord. i think this is the link https://discord.gg/7r7jZRWN

JPEscher commented 2 months ago

closing as he released a working version and this is now taken care of.