search

Jalle19 / eda-modbus-bridge

An HTTP/MQTT bridge for Enervent EDA ventilation units
GNU General Public License v3.0
15 stars 3 forks source link

Make HTTP service optional #17

Closed tomrosenback closed 2 years ago

tomrosenback commented 2 years ago

In Home Assistant HTTP is not needed as everything is handled through MQTT. Make the parameter optional and disable HTTP endpoints if not provided.

Jalle19 commented 2 years ago

Good idea

Jalle19 commented 2 years ago

I personally use the HTTP in combination with https://github.com/Jalle19/eda-influxdb to store the readings in InfluxDB. Now that there's MQTT support this could be done differently, but I guess the work is already done so no point in changing it anymore.

tomrosenback commented 2 years ago

Yes I figured you did so. Oh that makes me realize that I removed the HTTP ports from the config.json, which will as it stands break any HTTP calls. Can add that back.

Jalle19 commented 2 years ago

Can add that back.

Please do :D

tomrosenback commented 2 years ago

Did already :D