Expose device information over MQTT as well

Jalle19 / eda-modbus-bridge

An HTTP/MQTT bridge for Enervent EDA ventilation units

GNU General Public License v3.0

15 stars 3 forks source link

Expose device information over MQTT as well #19

Closed Jalle19 closed 2 years ago

Jalle19 commented 2 years ago

This would bring feature parity to the MQTT and HTTP APIs

tomrosenback commented 2 years ago

Which specific device information would you like to see in? And where?

Jalle19 commented 2 years ago

These values:

eda/deviceInformation/fanType "EC"
eda/deviceInformation/coolingTypeInstalled null
eda/deviceInformation/heatingTypeInstalled "EDE"
eda/deviceInformation/familyType "Pingvin"
eda/deviceInformation/serialNumber 0
eda/deviceInformation/softwareVersion 2.17

Jalle19 commented 2 years ago

Maybe these should be published once with retain set? I'm not that familiar with MQTT yet so I'm not sure if it's desirable here.

tomrosenback commented 2 years ago

Maybe, question is what they for are needed for as the information is shown in the Device info box and is already part of the device information in the discovery?

Jalle19 commented 2 years ago

It's mainly for feature parity with the HTTP API.