I spent a few hours this morning just closing tickets (#50, #17 and #76 ) and impatiently finishing everything up. "Move fast and break things" right?? .... ????
Major changes on UserProgressCharts, medium changes on AdminEmployeesTable, minor changes elsewhere.
I just altogether removed the "department goals" section from the top of the dashboard page. It wasn't doing anything and I couldn't think of anything really appealing to replace it with so bye bye.
There was a bug with getting goals with the loadData function (backend). It was using goalsService.read(personId) to get the goals but once I set up the userProgressCharts to actually use these goals the user view broke cause goalsService.read wasn't returning anything for any user except for blanfer since the only row we have in the goals table is personId = 1. So jtuminelli for example would be sending this request with personId = 2 and get nothing back - dashboard would crash because goals were undefined. I just changed loadData goals to goalsService.list()[0] to fix it
To Test:
Check out the user page progress charts, I changed them to match the admin progress charts (refactored the code too)
Take a gander at the progressCharts on mobile. Conditional rendering at different window widths ended up being more complicated to do than I expected, it checks screen width on page load and on window resize but not on whatever devTools does when you click the little mobile view button so be warned it isn't going to work when you do that (users won't be using devTools so I didn't bother trying to figure it out). If you're on blanfer boi you can just tab back and forth between "employees" and "profile" and it'll refresh these components
Try out the search and sort stuff on admin page employees table
Have a look at the header and footer, esp the footer cause I have my doubts about the color change on non-link text there
Changes:
I guess just check out the commit history it's all summed up there
I spent a few hours this morning just closing tickets (#50, #17 and #76 ) and impatiently finishing everything up. "Move fast and break things" right?? .... ???? Major changes on UserProgressCharts, medium changes on AdminEmployeesTable, minor changes elsewhere.
I just altogether removed the "department goals" section from the top of the dashboard page. It wasn't doing anything and I couldn't think of anything really appealing to replace it with so bye bye.
There was a bug with getting goals with the loadData function (backend). It was using goalsService.read(personId) to get the goals but once I set up the userProgressCharts to actually use these goals the user view broke cause goalsService.read wasn't returning anything for any user except for blanfer since the only row we have in the goals table is personId = 1. So jtuminelli for example would be sending this request with personId = 2 and get nothing back - dashboard would crash because goals were undefined. I just changed loadData goals to goalsService.list()[0] to fix it
To Test:
Changes: I guess just check out the commit history it's all summed up there