Footer (final?) - Githubissues

James-Lycett / workplace-wellness

0 stars 0 forks source link

Footer (final?) #9

Closed James-Lycett closed 3 months ago

James-Lycett commented 3 months ago

Updated the Footer to match the new design and cleaned up the frantic hackathon code a bit.

Here's a quick rundown of everything I did:

Changed the logo
Got everything positioned right
Removed the stuff that isn't in the design (social links etc)
Removed unnecessary/empty divs and stuff like className=""
Slapped in some react-icons in place of the icons that were there
Condensed some of the styling (moved repeat styles from individual elements and just put them on the whole container element)
Did a little mobile optimizin'

cozyfestiv commented 3 months ago

the only thing I might add is a fixed width for wide ass monitors like mine

you know so there's a big alley on each side. usually around 1280 wide. Like so. But that's really for the whole body.

cozyfestiv commented 3 months ago

Ok, I added a max-width and auto margin to the root div for large screens. Otherwise it looks great!

I just put it in the index.css since I wasn't sure how to target it using Tailwind, since it's not for an individual component

cozyfestiv commented 3 months ago

James-Lycett commented 3 months ago

That's a great solution I never would have even thought to do it like that! I suppose you see a lot of that with your big screen. Now I'm realizing I can simulate the effect of having a larger screen just by zooming out (i.e., ctrl/cmd + '-') which I've never even bothered to try before