search

James-Thorson / FishData

Compile and harmonize catch rates from fishery-independent surveys of fish populations
15 stars 10 forks source link

installation error #16

Open krtanaka opened 5 years ago

krtanaka commented 5 years ago

I keep getting the error below when I try to install the "FishData" package.

devtools::install_github("james-thorson/FishData") Error in loadNamespace(j <- i[[1L]], c(lib.loc, .libPaths()), versionCheck = vI[[j]]) : namespace ‘usethis’ 1.3.0 is being loaded, but >= 1.4.0 is required

It seems the error has something to do with "icesDatras; version "1.1=1" from GitHub no longer available.

ha0ye commented 5 years ago

Similar issue just now with installation, and I ended up installing from my fork with that check removed. @James-Thorson Is there a reason to specifically require 1.1.1 of icesDatras (it's now on 1.2.0)?

If not, I'm happy to do a PR updating the DESCRIPTION and including icesDatras as a dependency.

James-Thorson commented 5 years ago

I don't remember and don't closely maintain FishData, I'm happy to hear suggestions and accepted a pull request ;)

mebrooks commented 5 years ago

I'm having the same problem as @ha0ye, but I can't see where that check is enforced. I tried searching the code for icesDatras. @ha0ye, is it possible to push the change to your fork?

ha0ye commented 5 years ago

@mebrooks It's in zzz.R - I ended up deleting my fork and re-forking so that I can work on fixing this issue instead of the workaround (I'm not sure which bits of the loaded aphia name/codes FishData uses)

afredston commented 5 years ago

Are there any suggested workarounds for this issue? I'm having the same error when trying to install FishData (I have version 1.3-0 of icesDatras). Thanks for developing this great resource! 

Error: package or namespace load failed for ‘FishData’:
 .onAttach failed in attachNamespace() for 'FishData', details:
  call: fun(libname, pkgname)
  error: Must use `icesDatras` version `1.1=1` from GitHub
Error: loading failed
Execution halted
James-Thorson-NOAA commented 5 years ago

I suggest going through icesDatras to find the HASH for the old version of the package and installing that prior to trying FishData. I don't really maintain this actively, and I can't remember what changed to require that specific install, but it only affected the ices download capabilities. Alternatively, you could just copy the relevant code for your individual use, or I'd love to chat about a different governance system where someone else could maintain the package over hte medium- or long-term?

afredston commented 5 years ago

Thanks so much, I'll try one or both of those options! And I'll let you know if I end up using the package a lot, and in a position to help maintain it.