search

JaroslawWiosna / regionalizer

How to choose the best capital of a state and regions? Divider into regions, especially for administrative purposes
Mozilla Public License 2.0
2 stars 2 forks source link

Progress Bar unittest #100

Closed JaroslawWiosna closed 6 years ago

kermit10000000 commented 6 years ago

wow 100 commit ^_^ we should celebrate. btw. assert true(true) ?

JaroslawWiosna commented 6 years ago

@kermit10000000 Unfortunately, this is not working. please, have a look in travis job.

kermit10000000 commented 6 years ago

should we create issue for this bug?

JaroslawWiosna commented 6 years ago

@kermit10000000 Yeah... I think so, please, do it.

kermit10000000 commented 6 years ago

any progress?

JaroslawWiosna commented 6 years ago

I just do not know what is going on with travis.

kermit10000000 commented 6 years ago

maybe add comments like me in the unit test to see exacly in which place it fails or something?

coveralls commented 6 years ago

Coverage Status

Coverage increased (+3.2%) to 41.99% when pulling 62c6cdfc3c667106415bad7d7282114b2892df3b on ut into 4aad0086bd507b28b1cc666dfe1ba1afccf02a6e on master.

JaroslawWiosna commented 6 years ago

Let's merge it to the baseline. We can improve unittesting for ProgressBar in a separate pull request, what do you thinh, @kermit10000000 ?

kermit10000000 commented 6 years ago

Yeah we can have a basic test for now yet this unittests should be applied in the nearest future to fully test the class