search

JaroslawWiosna / regionalizer

How to choose the best capital of a state and regions? Divider into regions, especially for administrative purposes
Mozilla Public License 2.0
2 stars 2 forks source link

Region unittests #107

Closed kermit10000000 closed 6 years ago

kermit10000000 commented 6 years ago

Description

Region unittests should be made when the task with regio class refactoring will be closed

Release affected

Well... yes. We agreeded that when we deliver code we also deliver unittests so it should be done before v0.4.0

Priority

Medium as desribed above

Is there possible contributor who could fix the issue

kermit10000000 commented 6 years ago

@JaroslawWiosna will you do them when you finish the class?

JaroslawWiosna commented 6 years ago

As soon as #87 is finished. Give, me two hours.

JaroslawWiosna commented 6 years ago

87 is closed, @kermit10000000

kermit10000000 commented 6 years ago

i think it was done with https://github.com/JaroslawWiosna/regionalizer/pull/111/commits/9991f0bf00f67d410b5d8a82de896db786bdf8da and previous one. @JaroslawWiosna what is your opinion?

JaroslawWiosna commented 6 years ago

Yes, I think it could be closed.