search

JaroslawWiosna / regionalizer

How to choose the best capital of a state and regions? Divider into regions, especially for administrative purposes
Mozilla Public License 2.0
2 stars 2 forks source link

Bug in city constructor #108

Closed kermit10000000 closed 6 years ago

kermit10000000 commented 6 years ago

Description

Int instead of double. We have in the database the area field with the numbers after the dot that is or example 7.23 but we read only 7. If we loose the part after the comma the number won't be that precise and we are thinking here about mistakes in 0,1-10%. in the whole number. I know we do not use this field yet but it should be fixed when we will use it and the unittests should be fixed as well(currently we check the int number).

Release affected

Nope, we do not need this field.

Priority

Low Prio, to be fixed before we will want to use the Area Field

Is there possible contributor who could fix the issue

To be decided

kermit10000000 commented 6 years ago

decided to be double, fix will come with the unintests