search

JaroslawWiosna / regionalizer

How to choose the best capital of a state and regions? Divider into regions, especially for administrative purposes
Mozilla Public License 2.0
2 stars 2 forks source link

It will be combination of ClosestCity and Region but I experience som… #118

Closed kermit10000000 closed 6 years ago

kermit10000000 commented 6 years ago

…e weird compilator problems:

Maybe you will know: Region.cpp:(.text+0x5108): undefined reference to std::experimental::filesystem::v1::__cxx11::path::_M_split_cmpts()' Region.cpp:(.text+0x512a): undefined reference toDatabaseReader::readCitiesFromFile(std::experimental::filesystem::v1::cxx11::path const&)' Region.cpp:(.text+0x52b3): undefined reference to `ClosestCity::getAllBiggestCitiesInOrder(std::vector<City, std::allocator >, std::cxx11::basic_string<char, std::char_traits, std::allocator >)'

Signed-off-by: Wojciech Mielczarek kermit10000000@gmail.com

kermit10000000 commented 6 years ago

The given flag is not working. I have tried in many different orders etc. but the problem still occurs. I assume that since I did not have this problem before in the main it is caused by the presence of library in the Region class or the way we call things in the function(?). Anyway I do not know the solution so far and I can not find any working advice on the internet.

kermit10000000 commented 6 years ago

Combination of ClosestCity and Region. Moved to main.cpp as it is not compiling in the Region class in where it tries to use the #include <experimental/filesystem> from unknown reason.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 53.507% when pulling 20d3258b8cafa12f2aaca4ac70e2e0b9921b751c on regioclosest into 29195d337bf42597a805c2ef057953114cda4f68 on master.

JaroslawWiosna commented 6 years ago

https://stackoverflow.com/a/45332844

Anyways, we have some trouble with this fs. It won't compile even with this c++experimental linker flag. I think that we should get back to std::string instead of std::experimental::filesystem If clang is not happy about std::experimental::filesystem then it is the only solution.

kermit10000000 commented 6 years ago

Ok. So I will deliver this change now and later when we remove this as you said I will retry on making it in class Region.