search

JaroslawWiosna / regionalizer

How to choose the best capital of a state and regions? Divider into regions, especially for administrative purposes
Mozilla Public License 2.0
2 stars 2 forks source link

Clang-format checking in travis #119

Closed JaroslawWiosna closed 5 years ago

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.1%) to 55.449% when pulling 01bd1458c9ba66f4648c4e4ba52cdb287b1a0c39 on clang-format-in-travis into 56e92bbfb59620521da8082bef019f8be58a9377 on master.

JaroslawWiosna commented 6 years ago 
(cd .. && exec find regionalizer -iname *.hpp -o -iname *.cpp | xargs clang-format -i -style=file)

I am not sure if travis can handle this... Error reading /home/travis/build/JaroslawWiosna/regionalizer/.clang-format: Invalid argument

./check_coding_style.sh exits with 0, which is strage, because there is lcov directory. lcov is not a part of repo, so the script should always exit with 1. ...but it exits with 0. In general we want the script to return 0, but this time, when lcov directory exists, scrit should gives us 1. possible solutions:

  1. change git diff to `git diff --``
  2. use git status and check for string: working directory clean
JaroslawWiosna commented 6 years ago

@kermit10000000 yes, check 7168760 in https://github.com/JaroslawWiosna/regionalizer/commits/intentionally-made-coding-style-error

kermit10000000 commented 6 years ago

Ok, then please merge. Thank you for the answer,