JaroslawWiosna / regionalizer

How to choose the best capital of a state and regions? Divider into regions, especially for administrative purposes
Mozilla Public License 2.0
2 stars 2 forks source link

change usage of ClosestCity #94

Closed kermit10000000 closed 5 years ago

kermit10000000 commented 6 years ago

Descrpition

Make better use out of it than hard-coded Poddebice (that are just to prove it works)


Release affected

Yes it is part of 0.4.0 release but it is blocked( @JaroslawWiosna could you please comment when it will be possible ? )


Priority

Medium Prio - part of 0.4.0 release, no impact on other contributors work


Is there possible contributor who could fix the issue

Wojciech Mielczarek


JaroslawWiosna commented 6 years ago

@kermit10000000 It will be possible when #87 is closed

JaroslawWiosna commented 6 years ago

87 closed, so this task is not blocked anymore.

kermit10000000 commented 6 years ago

based on the console output do you have any idea where should we put the call of this function?

JaroslawWiosna commented 6 years ago

hmm..., just put it below the name of the new elected capital Like:

The best capital: Poddebice
which is near Zgierz->Lodz->Warszawa

Please, take care of this task ASAP

kermit10000000 commented 6 years ago

is this acceptable:
std::cout << "Which is near: " << ClosestCity::getAllBiggestCitiesInOrder(DatabaseReader::readCitiesFromFile("../database/cities_data"),subregion.getCapital()) << std::endl;

Or should it be hidden inside of some method or something?

kermit10000000 commented 6 years ago

Current look: obraz

kermit10000000 commented 6 years ago

Second look: obraz

kermit10000000 commented 6 years ago

I am also not sure about "which is near" . It looks like this: lodz: which is near Lodz... cos tam(w sensie zdoublowane dziwnie wyglada): obraz

kermit10000000 commented 6 years ago

Task will be moved to done but it might be improved when the change from fx will be done

JaroslawWiosna commented 5 years ago

Starting from scratch with 7e13971